From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master 96e61a9 26/26: Add packages/darkroom by merging its upstream subtree Date: Fri, 19 Dec 2014 16:48:36 -0500 Message-ID: References: <20141219190721.4296.62862@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1419025779 17658 80.91.229.3 (19 Dec 2014 21:49:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 19 Dec 2014 21:49:39 +0000 (UTC) Cc: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 19 22:49:32 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Y25QR-00086X-Mu for ged-emacs-devel@m.gmane.org; Fri, 19 Dec 2014 22:49:31 +0100 Original-Received: from localhost ([::1]:60659 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y25QQ-0004ar-Ur for ged-emacs-devel@m.gmane.org; Fri, 19 Dec 2014 16:49:30 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46381) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y25Q5-0004aD-64 for emacs-devel@gnu.org; Fri, 19 Dec 2014 16:49:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y25Pw-0007F4-V6 for emacs-devel@gnu.org; Fri, 19 Dec 2014 16:49:09 -0500 Original-Received: from mercure.iro.umontreal.ca ([132.204.24.67]:56208) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y25Pw-0007F0-RJ for emacs-devel@gnu.org; Fri, 19 Dec 2014 16:49:00 -0500 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 8F5DF850CB; Fri, 19 Dec 2014 16:49:00 -0500 (EST) Original-Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 5A88D1E5B8A; Fri, 19 Dec 2014 16:48:36 -0500 (EST) Original-Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id 3D60BB40DF; Fri, 19 Dec 2014 16:48:36 -0500 (EST) In-Reply-To: (Jo's message of "Fri, 19 Dec 2014 19:07:33 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 132.204.24.67 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:180357 Archived-At: > + (mapc #'(lambda (w) > + (with-selected-window w > + (darkroom--set-margins))) > + (get-buffer-window-list (current-buffer)))) I recommend the use of `dolist' instead of `mapc' when the body of the loop is provided by an anonymous function and we're looping over a list. If the compiler could tell that we're looping over a list, it could auto-transform the mapc call into a dolist (which is slightly more efficient), but having to expend it to a loop that handles both lists and arrays (like `mapc' does) makes the resulting code no more efficient than just using `mapc'. Stefan