From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: "João Távora" <joaotavora@gmail.com>
Subject: Re: [elpa] master 96e61a9 26/26: Add packages/darkroom by merging its upstream subtree
Date: Fri, 19 Dec 2014 16:48:36 -0500 [thread overview]
Message-ID: <jwvioh7cnzc.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <E1Y22th-0001CI-3B@vcs.savannah.gnu.org> (Jo's message of "Fri, 19 Dec 2014 19:07:33 +0000")
> + (mapc #'(lambda (w)
> + (with-selected-window w
> + (darkroom--set-margins)))
> + (get-buffer-window-list (current-buffer))))
I recommend the use of `dolist' instead of `mapc' when the body of the
loop is provided by an anonymous function and we're looping over a list.
If the compiler could tell that we're looping over a list, it could
auto-transform the mapc call into a dolist (which is slightly more
efficient), but having to expend it to a loop that handles both lists
and arrays (like `mapc' does) makes the resulting code no more efficient
than just using `mapc'.
Stefan
next parent reply other threads:[~2014-12-19 21:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20141219190721.4296.62862@vcs.savannah.gnu.org>
[not found] ` <E1Y22th-0001CI-3B@vcs.savannah.gnu.org>
2014-12-19 21:48 ` Stefan Monnier [this message]
2014-12-21 20:23 ` [elpa] master 96e61a9 26/26: Add packages/darkroom by merging its upstream subtree João Távora
2014-12-22 3:04 ` Stefan Monnier
2014-12-22 8:51 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvioh7cnzc.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.