From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master 6a098c6 15/19: Add ivy-mode Date: Thu, 16 Apr 2015 09:37:28 -0400 Message-ID: References: <20150416121807.21266.28456@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1429191470 23004 80.91.229.3 (16 Apr 2015 13:37:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 16 Apr 2015 13:37:50 +0000 (UTC) Cc: Oleh Krehel To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 16 15:37:42 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YijzA-00063x-FZ for ged-emacs-devel@m.gmane.org; Thu, 16 Apr 2015 15:37:40 +0200 Original-Received: from localhost ([::1]:36923 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YijzA-00073k-02 for ged-emacs-devel@m.gmane.org; Thu, 16 Apr 2015 09:37:40 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40742) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yijz6-00073R-QO for emacs-devel@gnu.org; Thu, 16 Apr 2015 09:37:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yijz3-0000TB-6T for emacs-devel@gnu.org; Thu, 16 Apr 2015 09:37:36 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:39430) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yijz3-0000Ss-1P for emacs-devel@gnu.org; Thu, 16 Apr 2015 09:37:33 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t3GDbSnY014337; Thu, 16 Apr 2015 09:37:28 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 23419F8A; Thu, 16 Apr 2015 09:37:28 -0400 (EDT) In-Reply-To: (Oleh Krehel's message of "Thu, 16 Apr 2015 12:18:14 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5278=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5278> : inlines <2729> : streams <1423442> : uri <1908223> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:185497 Archived-At: > + (cond ((functionp collection) > + (error "Function as a collection unsupported")) > + ((hash-table-p collection) > + (error "Hash table as a collection unsupported")) > + ((listp (car collection)) > + (setq collection (mapcar #'car collection)))) [...] > + (setq completing-read-function 'ivy-completing-read) Since completion-tables in the form of a function are pretty common nowadays (and becoming every time more frequent), this is a real problem: emacs -Q -l .../swiper/swiper-autoloads.el M-x ivy-mode RET C-x C-f C-x b Notice how both C-x C-f and C-x b signal errors. Stefan