all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: emacs-devel@gnu.org
Cc: Oleh Krehel <ohwoeowho@gmail.com>
Subject: Re: [elpa] master 6a098c6 15/19: Add ivy-mode
Date: Thu, 16 Apr 2015 09:37:28 -0400	[thread overview]
Message-ID: <jwviocwfb80.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <E1YiikI-0005aG-1X@vcs.savannah.gnu.org> (Oleh Krehel's message of "Thu, 16 Apr 2015 12:18:14 +0000")

> +  (cond ((functionp collection)
> +         (error "Function as a collection unsupported"))
> +        ((hash-table-p collection)
> +         (error "Hash table as a collection unsupported"))
> +        ((listp (car collection))
> +         (setq collection (mapcar #'car collection))))
[...]
> +      (setq completing-read-function 'ivy-completing-read)

Since completion-tables in the form of a function are pretty common
nowadays (and becoming every time more frequent), this is a real
problem:

   emacs -Q -l .../swiper/swiper-autoloads.el
   M-x ivy-mode RET
   C-x C-f
   C-x b

Notice how both C-x C-f and C-x b signal errors.


        Stefan



  parent reply	other threads:[~2015-04-16 13:37 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150416121807.21266.28456@vcs.savannah.gnu.org>
     [not found] ` <E1YiikF-0005ZU-F1@vcs.savannah.gnu.org>
2015-04-16 12:55   ` [elpa] master 0d619ea 10/19: counsel.el (couns-clj): Add with-no-warnings Stefan Monnier
     [not found] ` <E1YiikJ-0005ai-8x@vcs.savannah.gnu.org>
2015-04-16 12:59   ` [elpa] master 3b78e0e 18/19: swiper.el: Bump version Stefan Monnier
2015-04-16 12:57     ` Oleh Krehel
2015-04-16 17:48       ` Stefan Monnier
2015-04-16 17:53         ` Oleh Krehel
2015-04-16 18:52           ` Stefan Monnier
2015-04-16 18:50             ` Oleh Krehel
2015-04-16 19:36           ` Artur Malabarba
     [not found] ` <E1YiikI-0005aG-1X@vcs.savannah.gnu.org>
2015-04-16 13:37   ` Stefan Monnier [this message]
2015-04-16 13:34     ` [elpa] master 6a098c6 15/19: Add ivy-mode Oleh Krehel
2015-04-16 18:59       ` Stefan Monnier
2015-04-16 19:07         ` Oleh Krehel
2015-04-17 21:07     ` Dmitry Gutov
2015-04-17 21:25       ` Oleh Krehel
2015-04-17 21:37         ` Dmitry Gutov
2015-04-18  4:58         ` Stefan Monnier
2015-04-18 14:16           ` Stefan Monnier
2015-04-18 15:11             ` Oleh Krehel
2015-04-18 17:49               ` Stefan Monnier
2015-04-18 17:49                 ` Oleh Krehel
2015-04-19  2:12                   ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwviocwfb80.fsf-monnier+emacsdiffs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=ohwoeowho@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.