From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 255a011: Add `save-mark-and-excursion', which has the old `save-excursion' behavior Date: Tue, 05 May 2015 13:48:08 -0400 Message-ID: References: <20150504184829.1108.13525@vcs.savannah.gnu.org> <5547F4BB.1080804@dancol.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1430848244 18243 80.91.229.3 (5 May 2015 17:50:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 5 May 2015 17:50:44 +0000 (UTC) Cc: emacs-devel@gnu.org To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 05 19:50:26 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YpgzB-0004wB-Lq for ged-emacs-devel@m.gmane.org; Tue, 05 May 2015 19:50:25 +0200 Original-Received: from localhost ([::1]:41047 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YpgzB-0004b1-4l for ged-emacs-devel@m.gmane.org; Tue, 05 May 2015 13:50:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44803) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YpgxW-0001tL-0E for emacs-devel@gnu.org; Tue, 05 May 2015 13:48:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YpgxS-00049L-FG for emacs-devel@gnu.org; Tue, 05 May 2015 13:48:41 -0400 Original-Received: from mercure.iro.umontreal.ca ([132.204.24.67]:50987) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YpgxS-00048n-3c for emacs-devel@gnu.org; Tue, 05 May 2015 13:48:38 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 1B00385F64; Tue, 5 May 2015 13:48:37 -0400 (EDT) Original-Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id A39371E5B8D; Tue, 5 May 2015 13:48:08 -0400 (EDT) Original-Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id 89196B41A0; Tue, 5 May 2015 13:48:08 -0400 (EDT) In-Reply-To: <5547F4BB.1080804@dancol.org> (Daniel Colascione's message of "Mon, 04 May 2015 15:37:47 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 132.204.24.67 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:186253 Archived-At: > It is always a marker, isn't it? I think so, yes. > Some other parts of simple.el assume it always returns non-nil. > I'll remove the nil check. Good, thanks. >> IIUC activate-mark-hook should also be run when (eq omark nmark) but >> cur-mark-active was nil. > Huh. I just mechanically translated the original save-excursion C code. Ah, you're probably right: the save-excursion code had such kinds of problems. > I'll change the code to match the comment. Thanks, Stefan