From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#23019: parse-partial-sexp doesn't output the full state needed for its continuance. Date: Fri, 18 Mar 2016 15:40:34 -0400 Message-ID: References: <20160315091355.GA2263@acm.fritz.box> <20160317214934.GB9038@acm.fritz.box> <20160318191633.GC9433@acm.fritz.box> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1458330087 9228 80.91.229.3 (18 Mar 2016 19:41:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 18 Mar 2016 19:41:27 +0000 (UTC) Cc: 23019@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 18 20:41:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ah0Gl-0004Sl-IA for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 Mar 2016 20:41:11 +0100 Original-Received: from localhost ([::1]:45985 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ah0Gk-0001nW-PN for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 Mar 2016 15:41:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35454) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ah0Gg-0001kp-VO for bug-gnu-emacs@gnu.org; Fri, 18 Mar 2016 15:41:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ah0Gc-0000TC-Jr for bug-gnu-emacs@gnu.org; Fri, 18 Mar 2016 15:41:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55836) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ah0Gc-0000T8-GK for bug-gnu-emacs@gnu.org; Fri, 18 Mar 2016 15:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ah0Gc-0001Pd-BM for bug-gnu-emacs@gnu.org; Fri, 18 Mar 2016 15:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Mar 2016 19:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23019 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23019-submit@debbugs.gnu.org id=B23019.14583300415395 (code B ref 23019); Fri, 18 Mar 2016 19:41:02 +0000 Original-Received: (at 23019) by debbugs.gnu.org; 18 Mar 2016 19:40:41 +0000 Original-Received: from localhost ([127.0.0.1]:52963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ah0GH-0001Ox-M9 for submit@debbugs.gnu.org; Fri, 18 Mar 2016 15:40:41 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:51628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ah0GF-0001Ok-R9 for 23019@debbugs.gnu.org; Fri, 18 Mar 2016 15:40:40 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0A3FgA731xV/xSQs2tcgxCEAoVVwwsEAgKBPDwRAQEBAQEBAYEKQQWDXQEBAwEnLyMFCwsOBCISFBgNEBSINwjPIwEBAQEGAQEBAR6LOoUFB4QtBbUEI4I7gVkigngBAQE X-IPAS-Result: A0A3FgA731xV/xSQs2tcgxCEAoVVwwsEAgKBPDwRAQEBAQEBAYEKQQWDXQEBAwEnLyMFCwsOBCISFBgNEBSINwjPIwEBAQEGAQEBAR6LOoUFB4QtBbUEI4I7gVkigngBAQE X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="196706977" Original-Received: from 107-179-144-20.cpe.teksavvy.com (HELO pastel.home) ([107.179.144.20]) by ironport2-out.teksavvy.com with ESMTP; 18 Mar 2016 15:40:34 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 3BC065FE67; Fri, 18 Mar 2016 15:40:34 -0400 (EDT) In-Reply-To: <20160318191633.GC9433@acm.fritz.box> (Alan Mackenzie's message of "Fri, 18 Mar 2016 19:16:33 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115052 Archived-At: > I didn't give all that much thought to it. With a "local" state, > state.field will be addressed as a constant offset from the stack frame > base register. With a "remote" state, state->field will be addressed as > a constant offset from some address register. Provided the processor > has enough registers available, it shouldn't make a difference. But on > an architecture with a restricted set of registers (?old 80x86), it might > make things slower if an address register needs to be repeatedly loaded, > or even repeatedly stacked around function calls. That was my first reaction as well. But my other self was telling me "I can't say why, but my gut feeling says that this code is "cleaner" and should hence be easier to optimize". > So, at least on my machine, the "indirect" version is faster, by > around 1%. Not a great difference, but I'm surprised by the way > it went. Thanks for the test. As expected, it's a wash, but it's good to confirm that the cleaner version is at least no slower, Stefan