all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] emacs-25 ee04aed: Fix handling of buffer relocation in regex.c functions
Date: Tue, 25 Oct 2016 08:20:25 -0400	[thread overview]
Message-ID: <jwvinsgd3np.fsf-monnier+Inbox@gnu.org> (raw)
In-Reply-To: <83oa2934yl.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 24 Oct 2016 22:46:42 +0300")

>> How many of us know the constraints?  How many of those know them enough to
>> think about them when making changes?  How many of those get the answer
>> right when thinking about those problems?
> The same is true for many other parts of Emacs: bidi.c, syntax.c,
> composite.c, to name just a few.

I think it's worse because the answer to the question depends on
potentially the whole code (e.g. changing a piece of code such that it
now uses malloc means you have to check every caller (and caller's
caller, ...), and in other direction, when manipulating buffer text you
need to check every function you call (and the functions they call, ...)
to see if they may call malloc).

> Sure.  But we're already in the minefield, might as well be careful
> enough to not step on any mine, until we can get out.

I think we can get out right away.


        Stefan



  reply	other threads:[~2016-10-25 12:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20161023191028.10942.12099@vcs.savannah.gnu.org>
     [not found] ` <20161023191028.C103F220124@vcs.savannah.gnu.org>
2016-10-23 20:31   ` [Emacs-diffs] emacs-25 ee04aed: Fix handling of buffer relocation in regex.c functions Stefan Monnier
2016-10-24  6:25     ` Eli Zaretskii
2016-10-24 13:56       ` Stefan Monnier
2016-10-24 16:07         ` Eli Zaretskii
2016-10-24 19:01           ` Stefan Monnier
2016-10-24 19:46             ` Eli Zaretskii
2016-10-25 12:20               ` Stefan Monnier [this message]
2016-10-25 16:22                 ` Eli Zaretskii
2016-10-25 19:32                   ` Stefan Monnier
2016-10-25 19:40                     ` Eli Zaretskii
2016-10-25 19:59                       ` Stefan Monnier
2016-10-26  2:29                         ` Eli Zaretskii
2016-10-24 14:18       ` Stefan Monnier
2016-10-24 15:35         ` Eli Zaretskii
2016-11-04  8:37           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvinsgd3np.fsf-monnier+Inbox@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.