The with-slots macro shadows function names

The with-slots macro shadows function names

[Steven Allen]

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]


The following fails to compile on emacs 26 but compiles on emacs 25:

  (lambda (obj) (with-slots (message) obj (message "")))

It fails with:

  Eager macro-expansion failure: (invalid-function ((slot-value object (quote message))))

It appears to be substituting the `message` function name with
`(slot-value object 'message)`.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

Re: The with-slots macro shadows function names

[Stefan Monnier]

>>>>> "Steven" == Steven Allen <steven@stebalien.com> writes:

> The following fails to compile on emacs 26 but compiles on emacs 25:

>   (lambda (obj) (with-slots (message) obj (message "")))

> It fails with:

>   Eager macro-expansion failure: (invalid-function ((slot-value object (quote message))))

> It appears to be substituting the `message` function name with
> `(slot-value object 'message)`.

Please make it a bug report.  It's caused by:

    commit 0d112c00ba0ec14bd3014efcd3430b9ddcfe1fc1
    Author: Paul Pogonyshev <pogonyshev@gmail.com>
    Date:   Sun Mar 12 09:51:23 2017 +0100
    
        Fix bug in generator function with pcase (Bug#26068)
        
        * lisp/emacs-lisp/cl-macs.el (cl--sm-macroexpand): Remove some calls
        to symbol-name.


-- Stefan