From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: How can I undo a change from a modification-hook? Date: Thu, 27 Apr 2017 08:48:32 -0400 Message-ID: References: <2448005f-9fc4-78b2-3203-9fc8204f6f5b@mit.edu> <87fd6638-f46a-95f2-8b70-f271f5daeb63@gmail.com> <7f8bb205-c311-3360-ad0e-df205240199b@gmail.com> <2ee71c70-50a2-b054-ee87-5a28fc7776cb@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1493297337 14298 195.159.176.226 (27 Apr 2017 12:48:57 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 27 Apr 2017 12:48:57 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 27 14:48:52 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3iqq-0003a4-BI for ged-emacs-devel@m.gmane.org; Thu, 27 Apr 2017 14:48:52 +0200 Original-Received: from localhost ([::1]:60577 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d3iqu-0002Rr-Cu for ged-emacs-devel@m.gmane.org; Thu, 27 Apr 2017 08:48:56 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36613) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d3iqj-0002Ri-SA for emacs-devel@gnu.org; Thu, 27 Apr 2017 08:48:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d3iqf-0003l7-1X for emacs-devel@gnu.org; Thu, 27 Apr 2017 08:48:45 -0400 Original-Received: from [195.159.176.226] (port=44754 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d3iqe-0003l2-Qh for emacs-devel@gnu.org; Thu, 27 Apr 2017 08:48:40 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1d3iqW-0003II-Ny for emacs-devel@gnu.org; Thu, 27 Apr 2017 14:48:32 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 12 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:eLlmp0ZBRI4qIOmjVeqkGRhLGRE= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214338 Archived-At: > Of course, I could rewrite the queuing logic to be more resilient to this > kind of changes. But the question is about ways to prevent edits, and > I think it's more general than this particular example. Then I woulnd't worry too much about it: the cases where the after-hook is called "outside" of the before hook's beg/end are basically bugs and IIUC there are no known remaining cases in Emacs-26 (IIRC there are some known cases in Emacs-25 where this occurs, mostly in insert-file-contents (i.e. revert-buffer)). Stefan