From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Regarding Emacs, js.el, template-strings and syntax-tables Date: Thu, 24 Aug 2017 06:53:35 -0400 Message-ID: References: <1503557767.41308.1083341824.4A2103C1@webmail.messagingengine.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1503572061 22236 195.159.176.226 (24 Aug 2017 10:54:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 24 Aug 2017 10:54:21 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 24 12:54:14 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dkpm3-000580-Di for ged-emacs-devel@m.gmane.org; Thu, 24 Aug 2017 12:54:07 +0200 Original-Received: from localhost ([::1]:47725 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dkpm9-0005LD-HY for ged-emacs-devel@m.gmane.org; Thu, 24 Aug 2017 06:54:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36081) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dkply-0005Je-Tj for emacs-devel@gnu.org; Thu, 24 Aug 2017 06:54:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dkplu-00062e-Sz for emacs-devel@gnu.org; Thu, 24 Aug 2017 06:54:02 -0400 Original-Received: from [195.159.176.226] (port=39859 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dkplu-00062K-Mi for emacs-devel@gnu.org; Thu, 24 Aug 2017 06:53:58 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1dkplg-00043l-UE for emacs-devel@gnu.org; Thu, 24 Aug 2017 12:53:44 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 23 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:sssF5s9diUqByrSEyrOJzdSiLKw= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217755 Archived-At: >> function getGreeting(name) { >> let greeting = `Hello, ${name}!`; >> return greeting; >> } Indeed this problem has been with us in sh-script.el for many years. There are several different aspects at play: - how should font-lock display `name`. Should it have a normal face as if it weren't inside a string? Or should have a kind of combination of string-face and something else? - how should we handle nestings of such constructs. - several parts of Emacs like to know if we're inside code/string/comment (usually using (nth [3|4|8] (syntax-ppss))). Should these all consider "name" as being inside code? Or inside string? Or should we revisit all those cases one-by-one? In sh-script, we use syntax-propertize to make sure the whole string and its contents is all considered as a string and nothing else. This was the simplest solution and probably corresponds to the current behavior of js.el (and typescript.el) as well. Stefan