From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Lisp primitives and their calling of the change hooks Date: Sun, 07 Jan 2018 23:29:33 -0500 Message-ID: References: <20180106202403.GD23284@ACM> <20180107113628.GA22254@ACM> <83o9m599du.fsf@gnu.org> <20180107120859.GB22254@ACM> <20180107135629.GC22254@ACM> <83mv1p8vki.fsf@gnu.org> <83bmi58sao.fsf@gnu.org> <20180107194845.GE22254@ACM> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1515385714 12946 195.159.176.226 (8 Jan 2018 04:28:34 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 8 Jan 2018 04:28:34 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 08 05:28:30 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYP2w-0002te-KO for ged-emacs-devel@m.gmane.org; Mon, 08 Jan 2018 05:28:26 +0100 Original-Received: from localhost ([::1]:36294 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYP4w-0007mA-5b for ged-emacs-devel@m.gmane.org; Sun, 07 Jan 2018 23:30:30 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45373) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYP4J-0007lf-Kg for emacs-devel@gnu.org; Sun, 07 Jan 2018 23:29:52 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eYP4G-00055z-G9 for emacs-devel@gnu.org; Sun, 07 Jan 2018 23:29:51 -0500 Original-Received: from [195.159.176.226] (port=57682 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eYP4G-00055R-9P for emacs-devel@gnu.org; Sun, 07 Jan 2018 23:29:48 -0500 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1eYP27-0008LZ-Qg for emacs-devel@gnu.org; Mon, 08 Jan 2018 05:27:35 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 22 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:h/1hsvrdjJymCw6KJ3ps7ODeUyw= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:221702 Archived-At: > Yes, that's what I've done. Each zlib-decompress-region now has two > separate pairs of b/a-c-f, one for insert, then the other for delete. > This is the way that other "coding" primitives, like > base64-encode-region work. LGTM. >> In practice, I'd also expect both b-c-f and a-c-f to be nil (or >> equivalent) when we call zlib-decompress-region. > Yes. But it's nice to have things consistent. :-) Agreed. There's no justification for inconsistency here. > Anyhow, here's the patch, which appears to work as described above. Any > comments? Otherwise I'll commit it. The subsequent patch which tries to reduce the number of calls to bcf/acf seems worse because it's more complex (and the marginal benefit doesn't seem to justify the complexity). Stefan