all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Jackson Ray Hamilton <jackson@jacksonrayhamilton.com>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] feature/jsx 9e65e4b 3/3: Improve whitespace and unary keyword parsing
Date: Sun, 07 Apr 2019 21:02:07 -0400	[thread overview]
Message-ID: <jwvimvpz4yh.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <20190407230422.1469321115@vcs0.savannah.gnu.org> (Jackson Ray Hamilton's message of "Sun,  7 Apr 2019 19:04:21 -0400 (EDT)")

> +(defconst js--name-start-re (concat "[a-zA-Z_$]")
>    "Regexp matching the start of a JavaScript identifier, without grouping.")

BTW, my knowledge of Javascript is very limited, but IIUC its
identifiers are not limited to ASCII, so [[:alpha:]_$] is probably
a better regexp.


        Stefan



       reply	other threads:[~2019-04-08  1:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190407230419.19711.9506@vcs0.savannah.gnu.org>
     [not found] ` <20190407230422.1469321115@vcs0.savannah.gnu.org>
2019-04-08  1:02   ` Stefan Monnier [this message]
2019-04-08 15:43     ` [Emacs-diffs] feature/jsx 9e65e4b 3/3: Improve whitespace and unary keyword parsing Jackson Ray Hamilton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvimvpz4yh.fsf-monnier+emacsdiffs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=jackson@jacksonrayhamilton.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.