From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#35770: [PATCH] Broken duplicate case elimination in switch byte-compilation Date: Sun, 26 May 2019 18:06:54 -0400 Message-ID: References: <91DFE4D0-BDB6-4365-BA51-A2A3F209177C@acm.org> <752237291204505cd6b3fb98f667c2718fa6361f.camel@acm.org> <7C514C39-A204-44F4-A806-0B7DC3F4E6B4@acm.org> <83sgt67o2x.fsf@gnu.org> <87d0kaag5z.fsf@gmail.com> <83r28q7mxo.fsf@gnu.org> <838sut2h1e.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="76395"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , npostavs@gmail.com, vibhavp@gmail.com, 35770@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 27 00:08:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hV1JP-000Ja6-L5 for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 May 2019 00:08:16 +0200 Original-Received: from localhost ([127.0.0.1]:35750 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hV1JO-0000dN-LQ for geb-bug-gnu-emacs@m.gmane.org; Sun, 26 May 2019 18:08:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33483) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hV1JF-0000dB-LF for bug-gnu-emacs@gnu.org; Sun, 26 May 2019 18:08:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hV1JC-0004Cu-KP for bug-gnu-emacs@gnu.org; Sun, 26 May 2019 18:08:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38476) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hV1JC-0004Ch-I7 for bug-gnu-emacs@gnu.org; Sun, 26 May 2019 18:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hV1JC-0006wE-Bt for bug-gnu-emacs@gnu.org; Sun, 26 May 2019 18:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 May 2019 22:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35770 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35770-submit@debbugs.gnu.org id=B35770.155890843126606 (code B ref 35770); Sun, 26 May 2019 22:08:02 +0000 Original-Received: (at 35770) by debbugs.gnu.org; 26 May 2019 22:07:11 +0000 Original-Received: from localhost ([127.0.0.1]:52020 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hV1IK-0006v1-C4 for submit@debbugs.gnu.org; Sun, 26 May 2019 18:07:09 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:65161) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hV1II-0006uQ-2E for 35770@debbugs.gnu.org; Sun, 26 May 2019 18:07:06 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id AE1DB1011C4; Sun, 26 May 2019 18:07:00 -0400 (EDT) Original-Received: from mail02.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 828BE100C69; Sun, 26 May 2019 18:06:55 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1558908415; bh=9L58Qs8c2MNbMvTTbbspv9pyY7mQA9SvcqyJ0nsAFYM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=FuGH6oY9xxg5hWGoCd6BTnu8PlntYygYf2EMXFcaGmV+3DrWL8mb1BM+BzYCs/hKZ FSi1dTULaSy6wyYAEzKbuc/nlOr5uUYf/uLlrVa9+GjKqTzMxvU5+QcqJTTsNiqzNM iHvyXwHjRJQYpWwdVSUK6rnkWd2P8eOgWhNwAknJR9p+5hHTQ4OANih6thVFSQ+Jdw bRx7N5rkv34YjOLdW2We3K9biCFihCnPspLiF3pY8iaBpewKqVHIJtLRBEF0BaiWlM 1uU+BKeBmnNJy2s1uTW6E6i/AvszXINkoShsVohSei6b/0QUmW42sQ/NCoNWD0uwXh VOmZhdfY+YHFQ== Original-Received: from pastel (192-171-44-92.cpe.pppoe.ca [192.171.44.92]) by mail02.iro.umontreal.ca (Postfix) with ESMTPSA id 41A0A120ABE; Sun, 26 May 2019 18:06:55 -0400 (EDT) In-Reply-To: <838sut2h1e.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 26 May 2019 21:43:09 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159798 Archived-At: > More generally, I can't say I like this, and don't understand why this > would be better than reverting the offending change on emacs-26. Why > is it a problem to defer the features which caused the regression to > Emacs 27? I personally don't have a preference. I find reverting the change to be a more intrusive change with more risks of errors, but it's likely a wash either way. FWIW I also think it's generally good to introduce new byte-codes in one version and only enable the compiler to use them in the next version (that's what I did for the condition-case byte codes, for example). Stefan