all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "Mattias Engdegård" <mattiase@acm.org>,
	npostavs@gmail.com, vibhavp@gmail.com, 35770@debbugs.gnu.org
Subject: bug#35770: [PATCH] Broken duplicate case elimination in switch byte-compilation
Date: Sun, 26 May 2019 18:06:54 -0400	[thread overview]
Message-ID: <jwvimtwrhyt.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <838sut2h1e.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 26 May 2019 21:43:09 +0300")

> More generally, I can't say I like this, and don't understand why this
> would be better than reverting the offending change on emacs-26.  Why
> is it a problem to defer the features which caused the regression to
> Emacs 27?

I personally don't have a preference.  I find reverting the change to be
a more intrusive change with more risks of errors, but it's likely
a wash either way.

FWIW I also think it's generally good to introduce new byte-codes in one
version and only enable the compiler to use them in the next version
(that's what I did for the condition-case byte codes, for example).


        Stefan






  reply	other threads:[~2019-05-26 22:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-17  9:33 bug#35770: [PATCH] Broken duplicate case elimination in switch byte-compilation Mattias Engdegård
2019-05-17 12:16 ` Stefan Monnier
2019-05-17 14:48   ` Mattias Engdegård
2019-05-22 10:52     ` Mattias Engdegård
2019-05-22 10:58       ` Eli Zaretskii
2019-05-22 11:11         ` Mattias Engdegård
2019-05-22 11:21           ` Noam Postavsky
2019-05-22 11:23             ` Eli Zaretskii
2019-05-22 14:19               ` Stefan Monnier
2019-05-26 17:05                 ` Mattias Engdegård
2019-05-26 18:43                   ` Eli Zaretskii
2019-05-26 22:06                     ` Stefan Monnier [this message]
2019-05-27 11:27                       ` Mattias Engdegård
2019-06-01 13:58                         ` Noam Postavsky
2019-06-01 15:47                           ` Eli Zaretskii
2019-06-01 21:53                             ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvimtwrhyt.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=35770@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=mattiase@acm.org \
    --cc=npostavs@gmail.com \
    --cc=vibhavp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.