bug#36360: 'ada-mode' & 'svg' pkgs version number & presence problem

bug#36360: 'ada-mode' & 'svg' pkgs version number & presence problem

[Sebastian Urban]

1. After selecting in *Packages* (list-packages) 'ada-mode' and 'svg'
(both "available"), their descriptions show "Other versions: builtin."
without version number.

2. There are no "built-in" ("Status" column) versions of 'ada-mode'
and 'svg' on the package list *Packages*.


S. U.


In GNU Emacs 26.2 (build 1, i686-w64-mingw32)
  of 2019-04-13 built on CIRROCUMULUS
Repository revision: fd1b34bfba8f3f6298df47c8e10b61530426f749
Windowing system distributor 'Microsoft Corp.', version 6.1.7601

bug#36360: 'ada-mode' & 'svg' pkgs version number & presence problem

[Stefan Monnier]

Hi Lars,

> 2. There are no "built-in" ("Status" column) versions of 'ada-mode'
> and 'svg' on the package list *Packages*.

I see we have an `svg` package in GNU ELPA and an `svg` package
in Emacs.  There's no actual conflict, because they are "one and the
same", but they're not the same version.

A cursory look seems to indicate that the svg.el that comes from Emacs
is more up-to-date.  Would it make sense to use that one in GNU ELPA
(i.e. make `svg` into a `:core` package, built from emacs.git rather
than from elpa.git)?

The main question seems to be whether Emacs's svg.el works in Emacs-25
and if not whether we should bump up the package-requires or whether we
should tweak to code so it's made compatible with Emacs-25.


        Stefan

bug#36360: 'ada-mode' & 'svg' pkgs version number & presence problem

[Stefan Monnier]

> 2. There are no "built-in" ("Status" column) versions of 'ada-mode'
> and 'svg' on the package list *Packages*.

The patch below fixes it for ada-mode (a similar patch will do that for
svg, tho I'd like Lars to choose which version number we want to use
there).

Do you think it's safe enough for emacs-26 or should I keep it for
`master`?


        Stefan


diff --git a/lisp/progmodes/ada-mode.el b/lisp/progmodes/ada-mode.el
index 77c1e5e2d8..de323549ed 100644
--- a/lisp/progmodes/ada-mode.el
+++ b/lisp/progmodes/ada-mode.el
@@ -7,6 +7,7 @@
 ;;      Emmanuel Briot  <briot@gnat.com>
 ;; Maintainer: Stephen Leake <stephen_leake@stephe-leake.org>
 ;; Keywords: languages ada
+;; Version: 4.0
 
 ;; This file is part of GNU Emacs.
 

bug#36360: 'ada-mode' & 'svg' pkgs version number & presence problem

[Stefan Monnier]

> I see we have an `svg` package in GNU ELPA and an `svg` package
> in Emacs.  There's no actual conflict, because they are "one and the
> same", but they're not the same version.

BTW, the one in elpa.git has version "0.2" and the one in emacs.git has
no "Version:".  Whatever we decide to do, we'll need to give a version
number to the one in Emacs.
Should we go with 0.3 or should we leave some more room between the two?


        Stefan

bug#36360: 'ada-mode' & 'svg' pkgs version number & presence problem

[Lars Ingebrigtsen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> The main question seems to be whether Emacs's svg.el works in Emacs-25
> and if not whether we should bump up the package-requires or whether we
> should tweak to code so it's made compatible with Emacs-25.

I have made no effort to have svg.el be backwards-compatible with
previous Emacs versions, so it's probably not?  I can see a when-let* in
there, for instance...  That can be rewritten trivially, but I don't
know whether there's anything else that's "modern" in there.  :-)
Didn't see anything on a cursory scan.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#36360: 'ada-mode' & 'svg' pkgs version number & presence problem

[Lars Ingebrigtsen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> BTW, the one in elpa.git has version "0.2" and the one in emacs.git has
> no "Version:".  Whatever we decide to do, we'll need to give a version
> number to the one in Emacs.
> Should we go with 0.3 or should we leave some more room between the two?

Go to 1.0?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#36360: 'ada-mode' & 'svg' pkgs version number & presence problem

[Stefan Monnier]

>> BTW, the one in elpa.git has version "0.2" and the one in emacs.git has
>> no "Version:".  Whatever we decide to do, we'll need to give a version
>> number to the one in Emacs.
>> Should we go with 0.3 or should we leave some more room between the two?
>
> Go to 1.0?

OK, done, thanks


        Stefan

bug#36360: 'ada-mode' & 'svg' pkgs version number & presence problem

[Stefan Monnier]

Version: 26.3

I just pushed a fix for those two to `emacs-26`.


        Stefan