From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Date: Wed, 29 Jan 2020 16:23:51 -0500 Message-ID: References: <288610218.111246.1578330546916@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="88955"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 38992@debbugs.gnu.org, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , waah@yellowfrog.io To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 29 22:32:17 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iwuwa-000N2X-VP for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Jan 2020 22:32:17 +0100 Original-Received: from localhost ([::1]:51636 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iwuwZ-0001bY-QU for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Jan 2020 16:32:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59818) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iwupb-0006YD-SU for bug-gnu-emacs@gnu.org; Wed, 29 Jan 2020 16:25:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iwupa-0001ZG-SJ for bug-gnu-emacs@gnu.org; Wed, 29 Jan 2020 16:25:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56915) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iwupa-0001YG-LW for bug-gnu-emacs@gnu.org; Wed, 29 Jan 2020 16:25:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iwupa-0000PQ-IH for bug-gnu-emacs@gnu.org; Wed, 29 Jan 2020 16:25:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Jan 2020 21:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs Original-Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.15803330421493 (code B ref 38992); Wed, 29 Jan 2020 21:25:02 +0000 Original-Received: (at 38992) by debbugs.gnu.org; 29 Jan 2020 21:24:02 +0000 Original-Received: from localhost ([127.0.0.1]:34655 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iwuob-0000O0-KW for submit@debbugs.gnu.org; Wed, 29 Jan 2020 16:24:01 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:39485) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iwuoa-0000NY-7J for 38992@debbugs.gnu.org; Wed, 29 Jan 2020 16:24:00 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 9CEEB10031F; Wed, 29 Jan 2020 16:23:54 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id E43571000F2; Wed, 29 Jan 2020 16:23:52 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1580333032; bh=vEMi3E7rh0vk6jGB8Kisx3cjWhAG0jh15SHjyIifrs4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=DYLx5Ntz0y/vSpzrCMVOH8m3yK9NOYisgFkXY2V2kPN36SwI+TvUj/e7FhcDuMFr7 mHKK5NtGjMFbF7ntYauEm31GQw82wsHiQXeR2S+neWOFUh6Rs9MMZNOH+Gy4YU5mrW iOHRWJd/Hby/W2ugBpMDIn5M+kjjRfzBFJY0qlDJLJfYlLVcnwkmRueOp1yc6pntue 6oIR1FpT/zkoWAU1nRtP5USGtCU8ltmUthd5//NNZ9gCTquYY6m6WqB8yJNAtUyz4m NB2n1+OGrzouY3RUg4hPKqMPPM2fMpNq1cf2C7J680FX6OJvwY1uPpoWfeCq3267My hpC1390x2kGNw== Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 8CFE61203C7; Wed, 29 Jan 2020 16:23:52 -0500 (EST) In-Reply-To: (Dmitry Gutov's message of "Fri, 24 Jan 2020 17:31:20 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175410 Archived-At: >> It's arguably breaking compatibility. But you might be right that maybe >> it's a non issue. A quick `grep` shows that outside Emacs itself, at >> least Helm might be affected. > I don't disagree. But I'm not sure how to keep the backward > compatibility either. > > Unless the old variable is kept as-is (both assigned and referred to) and > the new one is looked up solely in one place > (minibuffer-force-complete-and-exit). This way, we can't mark the old > one as obsolete, though. Inded. > (BTW, at least one reference to minibuffer-completion-confirm in Emacs binds > it to t already; not sure what's the intended effect: > lisp/calc/calc-store.el:197). Maybe it used to be that `minibuffer-completion-confirm` used to be set to something like (not (memq require-match '(nil t)))? In any case, I do know it used to be that `minibuffer-completion-confirm` was only boolean. Stefan