From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: "modern" colors Re: Changes for emacs 28 Date: Sun, 13 Sep 2020 18:16:22 -0400 Message-ID: References: <20200910102000.2t6tsju745xutg7u@Ergus> <20200910110832.ko66gqnqo4l664d6@Ergus> <20200911134225.zhnlq7cdhmu2iraj@Ergus> <20200911221435.go7b5kz2zcvxp2ft@Ergus> <20200912153723.ymnq3i5pugqf7lsy@Ergus> <871rj628mq.fsf@elephly.net> <20200912195358.3zjct7gsogjtlh3n@Ergus> <87y2lezrbp.fsf@elephly.net> <83pn6pbtni.fsf@gnu.org> <87mu1tzlxo.fsf@elephly.net> <83mu1tbp7a.fsf@gnu.org> <87h7s1zccb.fsf@elephly.net> <878sddz72o.fsf@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30960"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: casouri@gmail.com, spacibba@aol.com, emacs-devel@gnu.org, ams@gnu.org, ghe@sdf.org, Eli Zaretskii , tecosaur@gmail.com To: Ricardo Wurmus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 14 00:22:08 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHaNs-0007wN-9A for ged-emacs-devel@m.gmane-mx.org; Mon, 14 Sep 2020 00:22:08 +0200 Original-Received: from localhost ([::1]:43584 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHaNr-0003VO-7B for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Sep 2020 18:22:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59274) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHaIV-00036k-MY for emacs-devel@gnu.org; Sun, 13 Sep 2020 18:16:35 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:4878) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHaIT-0001d9-3j; Sun, 13 Sep 2020 18:16:34 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 21AAD8009D; Sun, 13 Sep 2020 18:16:30 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 74E7980BAF; Sun, 13 Sep 2020 18:16:24 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1600035384; bh=cVsSAjULWelXSvCb6FTR+XskSI2CXf1PoqiZuEbk5Cc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=HYZ6QIAx4LRgi/hJ7e9BWy727dzFkJlhpEZjP9ghOptMXfpGHSSVGboYjrI5z63Kd eOPD2T3WfqMBSbRulkFtTAQjr5/yX5RA53VMCc822AV+bce7F1aWh/yoz5kZuEQIr6 LaqVRwBY+iNoPFVSh4BL87vFO/3GtaxW4xWD7kRiRLz+PiqTdVMxatdipmApop8iSn H9pqRvz4GxSjcsSmY5uLts4/AyOyzoAXk+Z1OnmmzrHdD+vKDw4TfS8xRuhwUdYEn6 8uic1y42Nt95EGJHsoTiF0D5k3wz3HXOrStPuKhtDvB1/GIrHvP8ckmV0LAfmrCRM7 QNpdb2twhyj5w== Original-Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 280E912066F; Sun, 13 Sep 2020 18:16:24 -0400 (EDT) In-Reply-To: <878sddz72o.fsf@elephly.net> (Ricardo Wurmus's message of "Sun, 13 Sep 2020 23:43:11 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/13 15:03:09 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:255585 Archived-At: >>> I suppose that=E2=80=99s exactly what gtk_selection_bg_color and >>> gtk_selection_fg_color are supposed to do: take the colours from the GTK >>> theme. >>> On Guix we build Emacs with the GTK toolkit. >> So the bug is that we obey the "external" settings for the region but >> apparently not for the `default` face. > There=E2=80=99s also a colour clash with the font-lock-comment-face and t= he > region when gtk_selection_bg_color happens to be dark (dark red on > black). Most faces have two settings depending on whether the default background id dark or light, so as long as we don't get the right default background color, your region face (which assumes a dark background) will likely clash with many other faces (which assume a light background). > Perhaps it=E2=80=99s a mistake to obey external colour settings at all, w= hen we > can only do it partially anyway. It's definitely a mistake to do it for a non-default face like `region` when we don't do it for `default`, indeed. Our faces are normally setup to work reasonably well with "any" sane default foreground/background (by choosing between the dark and the light "theme" based on the color of the default background), so I don't think it would be a mistake to obey external color settings for the default face. Stefan