From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "João Távora" <joaotavora@gmail.com>
Cc: "Mattias Engdegård" <mattiase@acm.org>,
"Lars Ingebrigtsen" <larsi@gnus.org>,
43489-done@debbugs.gnu.org
Subject: bug#43489: [PATCH] Don't signal scan-error when moving by sexp interactively
Date: Thu, 24 Sep 2020 13:32:37 -0400 [thread overview]
Message-ID: <jwvimc3nkzd.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CALDnm533MFwzBR+_5bnEn60Jgor5nh-knjh9=cdg4LfMdmoBnQ@mail.gmail.com> ("João Távora"'s message of "Thu, 24 Sep 2020 16:58:36 +0100")
> I disagree Mattias. I think swallowing errors is bad, generally.
Agreed, BUT the reason Matthias did it this way is that the error we get
currently from `scan-sexp` can't be turned into a good error message
without knowing that it was triggered during `forward-sexp`.
I think the right way to fix it is indeed not to catch&reraise the
error, but instead to:
A) improve the way errors are printed.
B) change scan-sexp so its errors can be used to generate a good error
message without having to know whether it occurred while running
forward-sexp or up-list.
I hoped this case would be a good opportunity to do (A), but sadly this
needs (B) to happen first and this one seemed less straightforward.
Help very welcome on this one.
Stefan
next prev parent reply other threads:[~2020-09-24 17:32 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 11:31 bug#43489: [PATCH] Don't signal scan-error when moving by sexp interactively Mattias Engdegård
2020-09-18 13:13 ` Lars Ingebrigtsen
2020-09-18 13:18 ` Dmitry Gutov
2020-09-18 13:42 ` Lars Ingebrigtsen
2020-09-18 13:48 ` Dmitry Gutov
2020-09-18 15:13 ` Mattias Engdegård
2020-09-18 15:23 ` Lars Ingebrigtsen
2020-09-18 16:01 ` Mattias Engdegård
2020-09-19 14:13 ` Lars Ingebrigtsen
2020-09-20 17:33 ` Mattias Engdegård
2020-09-20 19:54 ` Lars Ingebrigtsen
2020-09-21 10:55 ` Mattias Engdegård
2020-09-21 14:47 ` Lars Ingebrigtsen
2020-09-21 17:12 ` Mattias Engdegård
2020-09-22 14:32 ` Lars Ingebrigtsen
2020-09-23 9:17 ` Mattias Engdegård
2020-09-23 13:40 ` Lars Ingebrigtsen
2020-09-23 14:33 ` Mattias Engdegård
2020-09-23 14:45 ` João Távora
2020-09-23 16:24 ` Mattias Engdegård
2020-09-23 16:37 ` João Távora
2020-09-24 15:50 ` Mattias Engdegård
2020-09-24 15:58 ` João Távora
2020-09-24 17:32 ` Stefan Monnier [this message]
2020-09-24 19:23 ` João Távora
2020-09-28 17:05 ` Stefan Monnier
2020-09-20 21:39 ` Dmitry Gutov
2020-09-21 11:21 ` Mattias Engdegård
2020-09-21 12:36 ` Dmitry Gutov
2020-09-21 17:12 ` Mattias Engdegård
2020-09-21 17:49 ` Dmitry Gutov
2020-09-21 8:49 ` João Távora
2020-09-21 14:43 ` Lars Ingebrigtsen
2020-09-21 17:12 ` Mattias Engdegård
2020-09-21 17:25 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvimc3nkzd.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=43489-done@debbugs.gnu.org \
--cc=joaotavora@gmail.com \
--cc=larsi@gnus.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.