From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#19479: Package manager vulnerable to replay attacks Date: Wed, 25 Nov 2020 22:11:35 -0500 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29312"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 19479@debbugs.gnu.org, Noam Postavsky To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 26 04:12:23 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ki7hm-0007Wx-Ka for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Nov 2020 04:12:22 +0100 Original-Received: from localhost ([::1]:50108 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ki7hl-0007VY-Ml for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Nov 2020 22:12:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48496) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ki7hU-0007Nj-71 for bug-gnu-emacs@gnu.org; Wed, 25 Nov 2020 22:12:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54407) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ki7hS-0008Es-3m for bug-gnu-emacs@gnu.org; Wed, 25 Nov 2020 22:12:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ki7hR-0005Ll-Tf for bug-gnu-emacs@gnu.org; Wed, 25 Nov 2020 22:12:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Nov 2020 03:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19479 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: security Original-Received: via spool by 19479-submit@debbugs.gnu.org id=B19479.160636030520542 (code B ref 19479); Thu, 26 Nov 2020 03:12:01 +0000 Original-Received: (at 19479) by debbugs.gnu.org; 26 Nov 2020 03:11:45 +0000 Original-Received: from localhost ([127.0.0.1]:37720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ki7hB-0005LG-8c for submit@debbugs.gnu.org; Wed, 25 Nov 2020 22:11:45 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:26912) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ki7h9-0005L0-JC for 19479@debbugs.gnu.org; Wed, 25 Nov 2020 22:11:43 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 1D75810022E; Wed, 25 Nov 2020 22:11:38 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5E8B01001CB; Wed, 25 Nov 2020 22:11:36 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1606360296; bh=Y8KPfJDUkikJkdFbdETQkSUU0yyvfXvENIaZLOFoawU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=jKrkd/y+Rko6FqU7YWWvd7y9hlbP2rfuvikfin1KAiNemjMZcgCmBMiD4E9Ab+btW /wstbTmM/Z4hkytRR4YMmwr/nQ6HtFEqj69EsOmn6dQmCUSD3In8uCDCvHMV86XXjy lXPuO0ipaXaHtdoNmI3f83qn0KoxeYbww3yo7LewJ8rTBFHWRsuK2Xh9Zn5pDbWftI 8Odt1nwOBuaI3Ok1bK6eJbFgirFSF+F9oSLl0wnaLU+oJM5rODUITH/EuM6jMzCdMS IKivmXkBRDD/0IVKL+g7EpMjG4ElcB54v8ZY4LlNSxHj+t3l/OT08nj6LxfGGAqy3+ S1XLEoRAxYhBA== Original-Received: from alfajor (69-165-136-52.dsl.teksavvy.com [69.165.136.52]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1896C12014D; Wed, 25 Nov 2020 22:11:36 -0500 (EST) In-Reply-To: (Stefan Kangas's message of "Wed, 25 Nov 2020 22:02:32 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194257 Archived-At: > How about adding this check in addition to the checksum check? I think we should add this check in any case, yes. > Having two separate checks together should surely bring more > confidence than either of them would separately. That sounds like > good "defense in depth" thinking to me. I'm not sure the added hash is needed, but it seems reasonably harmless. >> I think we'd want to keep the signatures anyway, e.g. they can still be >> checked manually for old tarballs which aren't listed in >> `archive-contents` any more. And more generally they allow >> authenticating the origin of a package without having to look it up in >> `archive-contents`. > Valid points. Let's keep them indefinitely. Especially since some people seem interested to add commands to `package.el` to programatically install old packages. Stefan