all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Naoya Yamashita <conao3@gmail.com>
Cc: julien@danjou.info, emacs-devel@gnu.org
Subject: Re: Add oauth2 customize group (resolve FIXME)
Date: Fri, 19 Feb 2021 10:14:44 -0500	[thread overview]
Message-ID: <jwvim6o5bz6.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20210219.201355.1324938630727300892.conao3@gmail.com> (Naoya Yamashita's message of "Fri, 19 Feb 2021 20:13:55 +0900 (JST)")

Hi,

> The commit `author` should be `Naoya Yamashita <conao3@gmail.com>`.
>
> You may think it's a small thing, but OSS contributors are
> motivated by commits being properly marked as my contribution, so
> pushing inappropriate commits may demotivate them.
>
> This time is okay, but please pay attention to the Author field next time!

Very well said, thank you for reminding us (copyright attribution is
also another reason why we want to be careful with it).


        Stefan




  reply	other threads:[~2021-02-19 15:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-19  1:16 Add oauth2 customize group (resolve FIXME) Naoya Yamashita
2021-02-19 10:17 ` Julien Danjou
2021-02-19 11:13   ` Naoya Yamashita
2021-02-19 15:14     ` Stefan Monnier [this message]
2021-02-19 16:57       ` Naoya Yamashita

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvim6o5bz6.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=conao3@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=julien@danjou.info \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.