all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Campbell Barton <ideasman42@gmail.com>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: Support for undo-amalgamate in a version of the atomic-change-group macro (with patch)
Date: Sun, 07 Nov 2021 08:21:51 -0500	[thread overview]
Message-ID: <jwvilx45cpu.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CAEcf3Nw1MmW56nxFA=DGqRRMAOY14MTBP26CQOPyf29_YDH55A@mail.gmail.com> (Campbell Barton's message of "Sun, 7 Nov 2021 19:45:54 +1100")

> Here is an updated patch with a separate macro to amalgamate undo barriers.

Looks pretty good, thanks.
I was about to install it into `master` but noticed the following:

- You seem not to have signed copyright paperwork yet.  If you're OK
  with it, please fill the form below and send it to the FSF so they can
  send you the relevant paperwork to sign.
  [ The change is sufficiently small that we can accept it right away,
    but since the paperwork process takes some time, it's good to do it
    "in advance" so it's out of the way for your next contributions.  ]

- I see the macro binds undo limits, but AFAICT this is an "accident"
  resulting from copy&pasting code from the other macro: for the
  atomic-change macro it's very important that undo info is not thrown
  away since the macro uses the undo info internally to cancel changes
  on error, but for this macro I can't see any harm in having the undo
  info truncated, so I think we shouldn't change the undo limit
  vars.  WDYT?


        Stefan




  reply	other threads:[~2021-11-07 13:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-29  1:48 Support for undo-amalgamate in a version of the atomic-change-group macro (with patch) Campbell Barton
2021-11-01 17:43 ` Stefan Monnier
2021-11-02  1:04   ` Campbell Barton
2021-11-02  2:14     ` Stefan Monnier
2021-11-02  2:14     ` Campbell Barton
2021-11-07  8:45       ` Campbell Barton
2021-11-07 13:21         ` Stefan Monnier [this message]
2021-11-07 23:09           ` Campbell Barton
2021-11-07 23:29             ` Campbell Barton
2021-11-08  4:39             ` Stefan Monnier
2021-11-08  4:46               ` Lars Ingebrigtsen
2021-11-08  5:41                 ` Campbell Barton
2021-11-08 13:40                   ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvilx45cpu.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=ideasman42@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.