all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Noboru Ota <me@nobiot.com>
Cc: emacs-devel@gnu.org
Subject: Re: [ELPA] Submitting new package Org-remark
Date: Sat, 29 Jan 2022 17:26:02 -0500	[thread overview]
Message-ID: <jwvilu22xur.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <8635l6ga7v.fsf@nobiot.com> (Noboru Ota's message of "Sat, 29 Jan 2022 10:30:44 +0100")

[ BTW, your package didn't build yet because of:

    ======== Building tarball archive-devel/org-remark-0.2.0.0.20220129.95541.tar...
    Problem with copyright notices:
    Missing copyright notice in org-remark/demo/custom-pens.el
    Build error for archive-devel/org-remark-0.2.0.0.20220129.95541.tar: (error "Abort")
    ######## Build of package archive-devel/org-remark-0.2.0.0.20220129.95541.tar FAILED!! ]

> I would like to use an ASCII export of README.org, not the raw
> README.org file for the package description.

The current scripts generate an HTML version of `README.org` for the
webpage and an ASCII version for the `<pkg>-readme.txt` (used by
`list-packages`) from the :readme, so I think it should be better
overall, and it definitely should not use the raw Org text any more.

> Currently, `describe-package' shows the raw `README.org` *after* the
> package has been installed.

This should depend on when the package was built: the scripts were
changed a month or two ago and they only affect those packages that have
been rebuilt since.

> 1. Before the user installs a package, `describe-package` (and
>    `package-list-packages`) displays `package-name-readme.txt`.  ELPA
>    generates it and when `README.org` is used as the README file, it
>    gets exported to ASCII plain text (I believe this is done in
>    functions `elpaa--get-README' and `elpaa--section-to-plain-text' in
>    elpa-admin.el)

That's right.

> 2. After the user has installed a package, `describe-package` (and
>    `package-list-packages`) displays one of these files: "README-elpa"
>    "README-elpa.md" "README" "README.rst" "README.org".  When
>    `README.org` is used, the raw text is displayed without being
>    exported to ASCII format (I believe this is done in function
>    `describe-package-1' and `package--get-description')

Oh, my!  You're absolutely right.  I wasn't aware of this code in
`describe-packages`.  We should improve it to use the same approach as
in `elpaa--get-README` and `elpaa--section-to-plain-text` (tho maybe
using some other part of Org which renders directly in an Emacs buffer
rather than a txt file, so it looks better).

There's also the problem that `describe-package` doesn't have access to the
spec we put in `elpa-packages`, so it can only guess which README file
to use based on a heuristic.

Any chance you'd be interested in improving `describe-package`?


        Stefan




  reply	other threads:[~2022-01-29 22:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-28 19:07 [ELPA] Submitting new package Org-remark Noboru Ota
2022-01-28 21:05 ` Stefan Monnier
2022-01-29  9:30   ` Noboru Ota
2022-01-29 22:26     ` Stefan Monnier [this message]
2022-01-30  9:37       ` Noboru Ota
2022-01-30 16:13         ` Stefan Monnier
2022-01-29 20:36 ` Uwe Brauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvilu22xur.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=me@nobiot.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.