Re: master df49e3a3ab 3/3: Merge branch 'master' of /home/acm/emacs/emacs.git/master

Re: master df49e3a3ab 3/3: Merge branch 'master' of /home/acm/emacs/emacs.git/master

[Lars Ingebrigtsen]

Alan Mackenzie <acm@muc.de> writes:

>     Merge branch 'master' of /home/acm/emacs/emacs.git/master

I'm not sure that it's this merge that's causing this, but these started
happening around that time.

To reproduce, I do a "make -j16 bootstrap" on Debian/bookworm, and I get
a whole lot of:

Compiler-macro error for cl-member: Handler: cl--compiler-macro-member
(excessive-variable-binding)
Eager macro-expansion failure: (excessive-variable-binding)
Compiler-macro error for cl-member: Handler: cl--compiler-macro-member
(excessive-variable-binding)
Eager macro-expansion failure: (excessive-variable-binding)
Compiler-macro error for cl-member: Handler: cl--compiler-macro-member
(excessive-variable-binding)
Eager macro-expansion failure: (excessive-variable-binding)
Compiler-macro error for cl-member: Handler: cl--compiler-macro-member
(excessive-variable-binding)
Eager macro-expansion failure: (excessive-variable-binding)


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master df49e3a3ab 3/3: Merge branch 'master' of /home/acm/emacs/emacs.git/master

[Alan Mackenzie]

Hello, Lars.

On Mon, Jan 24, 2022 at 09:12:35 +0100, Lars Ingebrigtsen wrote:
> Alan Mackenzie <acm@muc.de> writes:

> >     Merge branch 'master' of /home/acm/emacs/emacs.git/master

> I'm not sure that it's this merge that's causing this, but these started
> happening around that time.

> To reproduce, I do a "make -j16 bootstrap" on Debian/bookworm, and I get
> a whole lot of:

> Compiler-macro error for cl-member: Handler: cl--compiler-macro-member
> (excessive-variable-binding)
> Eager macro-expansion failure: (excessive-variable-binding)
> Compiler-macro error for cl-member: Handler: cl--compiler-macro-member
> (excessive-variable-binding)
> Eager macro-expansion failure: (excessive-variable-binding)
> Compiler-macro error for cl-member: Handler: cl--compiler-macro-member
> (excessive-variable-binding)
> Eager macro-expansion failure: (excessive-variable-binding)
> Compiler-macro error for cl-member: Handler: cl--compiler-macro-member
> (excessive-variable-binding)
> Eager macro-expansion failure: (excessive-variable-binding)

I don't see these at all, any more, just clean builds.  OK, I'm doing
"make -j17 bootstrap", not "-j16", but that shouldn't make a difference.

What is your ./configure command line?  Mine is

   $ ./configure --with-gif=no --with-tiff=no --with-gpm \
   --with-native-compilation

..  If this doesn't clear up, somehow, perhaps you could send me the
stdout and stderr from a build, possibly together using 2>&1.

> -- 
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: master df49e3a3ab 3/3: Merge branch 'master' of /home/acm/emacs/emacs.git/master

[Lars Ingebrigtsen]

Alan Mackenzie <acm@muc.de> writes:

> I don't see these at all, any more, just clean builds.  OK, I'm doing
> "make -j17 bootstrap", not "-j16", but that shouldn't make a difference.
>
> What is your ./configure command line?  Mine is
>
>    $ ./configure --with-gif=no --with-tiff=no --with-gpm \
>    --with-native-compilation

I'm just doing ./configure.  (So it's without nativecomp.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master df49e3a3ab 3/3: Merge branch 'master' of /home/acm/emacs/emacs.git/master

[Alan Mackenzie]

Hello, Lars.

On Mon, Jan 24, 2022 at 12:29:35 +0100, Lars Ingebrigtsen wrote:
> Alan Mackenzie <acm@muc.de> writes:

> > I don't see these at all, any more, just clean builds.  OK, I'm doing
> > "make -j17 bootstrap", not "-j16", but that shouldn't make a difference.

> > What is your ./configure command line?  Mine is

> >    $ ./configure --with-gif=no --with-tiff=no --with-gpm \
> >    --with-native-compilation

> I'm just doing ./configure.  (So it's without nativecomp.)

Ah!  When I take the --with-native-compilation out, I get a single
instance of

Compiler-macro error for cl-member: Handler: cl--compiler-macro-member
(excessive-variable-binding)
Eager macro-expansion failure: (excessive-variable-binding)

in my stderr.

So, I'll have a look at clearing that up, in the hope that it's the same
bug as you're seeing.

> -- 
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: master df49e3a3ab 3/3: Merge branch 'master' of /home/acm/emacs/emacs.git/master

[Lars Ingebrigtsen]

With nativecomp, I get this test failure:

1 unexpected results:
   FAILED  comp-tests-ret-type-spec-55

I have no idea whether it's related to your bytecomp fixes or not, but I
think it started happening around the time of the merge?  Can you take a
look at that, too?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master df49e3a3ab 3/3: Merge branch 'master' of /home/acm/emacs/emacs.git/master

[Alan Mackenzie]

Hello, Lars.

On Mon, Jan 24, 2022 at 11:44:49 +0000, Alan Mackenzie wrote:
> On Mon, Jan 24, 2022 at 12:29:35 +0100, Lars Ingebrigtsen wrote:
> > Alan Mackenzie <acm@muc.de> writes:

> > > I don't see these at all, any more, just clean builds.  OK, I'm doing
> > > "make -j17 bootstrap", not "-j16", but that shouldn't make a difference.

> > > What is your ./configure command line?  Mine is

> > >    $ ./configure --with-gif=no --with-tiff=no --with-gpm \
> > >    --with-native-compilation

> > I'm just doing ./configure.  (So it's without nativecomp.)

> Ah!  When I take the --with-native-compilation out, I get a single
> instance of

> Compiler-macro error for cl-member: Handler: cl--compiler-macro-member
> (excessive-variable-binding)
> Eager macro-expansion failure: (excessive-variable-binding)

> in my stderr.

> So, I'll have a look at clearing that up, in the hope that it's the same
> bug as you're seeing.

I had problems getting a dump, because it took time to diagnose a bug in
signal_or_quit (eval.c) where Vdebugger got bound instead of Qdebugger.
This will soon be fixed.

The main problem was max_specpdl_size was too small for generating
leim-list.el.  After I doubled it from 2500 to 5000 for that particular
step, I got a clean build.

More to follow later, when I've got more time.  ;-(    

> > -- 
> > (domestic pets only, the antidote for overdose, milk.)
> >    bloggy blog: http://lars.ingebrigtsen.no

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: master df49e3a3ab 3/3: Merge branch 'master' of /home/acm/emacs/emacs.git/master

[Alan Mackenzie]

Hello, Lars.

On Mon, Jan 24, 2022 at 14:45:25 +0100, Lars Ingebrigtsen wrote:
> With nativecomp, I get this test failure:

> 1 unexpected results:
>    FAILED  comp-tests-ret-type-spec-55

> I have no idea whether it's related to your bytecomp fixes or not, but I
> think it started happening around the time of the merge?  Can you take a
> look at that, too?

Yes, that was caused by a particular optimisation in comp.el.  I've been
meaning to ask Andrea about this since he got back from holiday.

Whilst not desirable, it seems to be a pretty harmless error.

> -- 
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: master df49e3a3ab 3/3: Merge branch 'master' of /home/acm/emacs/emacs.git/master

[Alan Mackenzie]

Hello, Lars.

On Mon, Jan 24, 2022 at 09:12:35 +0100, Lars Ingebrigtsen wrote:
> Alan Mackenzie <acm@muc.de> writes:

> >     Merge branch 'master' of /home/acm/emacs/emacs.git/master

> I'm not sure that it's this merge that's causing this, but these started
> happening around that time.

> To reproduce, I do a "make -j16 bootstrap" on Debian/bookworm, and I get
> a whole lot of:

> Compiler-macro error for cl-member: Handler: cl--compiler-macro-member
> (excessive-variable-binding)
> Eager macro-expansion failure: (excessive-variable-binding)
> Compiler-macro error for cl-member: Handler: cl--compiler-macro-member
> (excessive-variable-binding)
> Eager macro-expansion failure: (excessive-variable-binding)
> Compiler-macro error for cl-member: Handler: cl--compiler-macro-member
> (excessive-variable-binding)
> Eager macro-expansion failure: (excessive-variable-binding)
> Compiler-macro error for cl-member: Handler: cl--compiler-macro-member
> (excessive-variable-binding)
> Eager macro-expansion failure: (excessive-variable-binding)

As I said earlier, I only saw one of these on a vanilla ./configure.  The
problem was in max_specpdl_size (2500) being inadequate for the
generation of leim-list.el.

The following fixes it for me.  Could you try it, please, and see if it
fixes it for you, too.  Thanks!



diff --git a/leim/Makefile.in b/leim/Makefile.in
index 2a477d868b..6cf0abb40c 100644
--- a/leim/Makefile.in
+++ b/leim/Makefile.in
@@ -122,6 +122,7 @@ leim-list.el:
 ${leimdir}/leim-list.el: ${srcdir}/leim-ext.el ${TIT_MISC}
 	$(AM_V_GEN)rm -f $@
 	$(AM_V_at)${RUN_EMACS} -l international/quail \
+	  --eval "(setq max-specpdl-size 5000)" \
 	  --eval "(update-leim-list-file (unmsys--file-name \"${leimdir}\"))"
 	$(AM_V_at)sed -n -e '/^[^;]/p' -e 's/^;\(;*\)inc /;\1 /p' < $< >> $@
 


> -- 
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: master df49e3a3ab 3/3: Merge branch 'master' of /home/acm/emacs/emacs.git/master

[Lars Ingebrigtsen]

Alan Mackenzie <acm@muc.de> writes:

> The following fixes it for me.  Could you try it, please, and see if it
> fixes it for you, too.  Thanks!

Yes, that fixes the issue for me, too.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

max-specpdl-size (was: master df49e3a3ab 3/3: Merge branch 'master' of /home/acm/emacs/emacs.git/master)

[Stefan Monnier]

> As I said earlier, I only saw one of these on a vanilla ./configure.  The
> problem was in max_specpdl_size (2500) being inadequate for the
> generation of leim-list.el.

Reminds me: why do we have/need max-specpdl-size?
AFAICT it's redundant with `max-lisp-eval-depth`.


        Stefan

Re: master df49e3a3ab 3/3: Merge branch 'master' of /home/acm/emacs/emacs.git/master

[Alan Mackenzie]

Hello, Lars.

On Sun, Jan 30, 2022 at 17:09:32 +0100, Lars Ingebrigtsen wrote:
> Alan Mackenzie <acm@muc.de> writes:

> > The following fixes it for me.  Could you try it, please, and see if it
> > fixes it for you, too.  Thanks!

> Yes, that fixes the issue for me, too.

Oh, good!  I've committed the fix to master.

> -- 
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: master df49e3a3ab 3/3: Merge branch 'master' of /home/acm/emacs/emacs.git/master

[Lars Ingebrigtsen]

Alan Mackenzie <acm@muc.de> writes:

>> > The following fixes it for me.  Could you try it, please, and see if it
>> > fixes it for you, too.  Thanks!
>
>> Yes, that fixes the issue for me, too.
>
> Oh, good!  I've committed the fix to master.

Darn, I spoke to soon -- I did a "make bootstrap" and forgot that it
didn't clear out all the files.  I'm still seeing these errors:

Eager macro-expansion failure: (excessive-variable-binding)
  INFO     Scraping files for hol-loaddefs.el...43% 
Compiler-macro error for cl-member: Handler: cl--compiler-macro-member
(excessive-variable-binding)
Eager macro-expansion failure: (excessive-variable-binding)
  INFO     Scraping files for hol-loaddefs.el...76% 
  INFO     Scraping files for hol-loaddefs.el...done
Compiler-macro error for cl-member: Handler: cl--compiler-macro-member
(excessive-variable-binding)
Eager macro-expansion failure: (excessive-variable-binding)
Compiler-macro error for cl-member: Handler: cl--compiler-macro-member
(excessive-variable-binding)

etc.

This is with

git clean -xf
make -j16


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master df49e3a3ab 3/3: Merge branch 'master' of /home/acm/emacs/emacs.git/master

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> git clean -xf
> make -j16

Single-threaded make is more helpful:

  GEN      ../../lisp/cedet/semantic/bovine/c-by.el
Loading /home/larsi/src/emacs/trunk/lisp/cedet/semantic/grm-wy-boot.el (source)...
Compiler-macro error for cl-member: Handler: cl--compiler-macro-member
(excessive-variable-binding)
Eager macro-expansion failure: (excessive-variable-binding)
  GEN      ../../lisp/cedet/semantic/bovine/make-by.el
Loading /home/larsi/src/emacs/trunk/lisp/cedet/semantic/grm-wy-boot.el (source)...
Compiler-macro error for cl-member: Handler: cl--compiler-macro-member
(excessive-variable-binding)
Eager macro-expansion failure: (excessive-variable-binding)
  GEN      ../../lisp/cedet/semantic/bovine/scm-by.el
Loading /home/larsi/src/emacs/trunk/lisp/cedet/semantic/grm-wy-boot.el (source).

So it's coming from all the bovine stuff.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master df49e3a3ab 3/3: Merge branch 'master' of /home/acm/emacs/emacs.git/master

[Alan Mackenzie]

Hello, Lars.

On Sun, Jan 30, 2022 at 19:26:49 +0100, Lars Ingebrigtsen wrote:
> Lars Ingebrigtsen <larsi@gnus.org> writes:

> > git clean -xf
> > make -j16

> Single-threaded make is more helpful:

>   GEN      ../../lisp/cedet/semantic/bovine/c-by.el
> Loading /home/larsi/src/emacs/trunk/lisp/cedet/semantic/grm-wy-boot.el (source)...
> Compiler-macro error for cl-member: Handler: cl--compiler-macro-member
> (excessive-variable-binding)
> Eager macro-expansion failure: (excessive-variable-binding)
>   GEN      ../../lisp/cedet/semantic/bovine/make-by.el
> Loading /home/larsi/src/emacs/trunk/lisp/cedet/semantic/grm-wy-boot.el (source)...
> Compiler-macro error for cl-member: Handler: cl--compiler-macro-member
> (excessive-variable-binding)
> Eager macro-expansion failure: (excessive-variable-binding)
>   GEN      ../../lisp/cedet/semantic/bovine/scm-by.el
> Loading /home/larsi/src/emacs/trunk/lisp/cedet/semantic/grm-wy-boot.el (source).

> So it's coming from all the bovine stuff.

Thanks, that was helpful.

The same trick as before, namely increasing max-specpdl-size from 2500
to 5000 appears to work here, too.

Would you please try out the following, and confirm that it works.  Then
I'll commit it to master.  Though, come to think of it, it could
probably do with a line break.

Thanks!



diff --git a/admin/grammars/Makefile.in b/admin/grammars/Makefile.in
index 6f69943089..2cfaff361e 100644
--- a/admin/grammars/Makefile.in
+++ b/admin/grammars/Makefile.in
@@ -34,7 +34,7 @@ top_builddir =
 unexport EMACSDATA EMACSDOC EMACSLOADPATH EMACSPATH
 
 EMACS = ${top_builddir}/src/emacs
-emacs = "${EMACS}" -batch --no-site-file --no-site-lisp --eval '(setq load-prefer-newer t)'
+emacs = "${EMACS}" -batch --no-site-file --no-site-lisp --eval '(setq max-specpdl-size 5000)' --eval '(setq load-prefer-newer t)'
 
 make_bovine = ${emacs} -l semantic/bovine/grammar -f bovine-batch-make-parser
 make_wisent = ${emacs} -l semantic/wisent/grammar -f wisent-batch-make-parser


> -- 
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no

Re: master df49e3a3ab 3/3: Merge branch 'master' of /home/acm/emacs/emacs.git/master

[Lars Ingebrigtsen]

Alan Mackenzie <acm@muc.de> writes:

> Would you please try out the following, and confirm that it works.  Then
> I'll commit it to master.  Though, come to think of it, it could
> probably do with a line break.

Thanks; I can confirm that with "git clean -xf; make" I don't get any of
those errors, so please go ahead and push.

But I'm seeing some warnings in the build now that I think probably are
totally unrelated to this stuff --

In end of data:
org/org.el:18501:4: Warning: the function `browse-url' might not be defined at runtime.
org/org.el:9570:42: Warning: the function `cl-position' might not be defined at runtime.
org/org.el:9562:18: Warning: the function `cl-find-if-not' might not be defined at runtime.
org/org.el:9554:24: Warning: the function `cl-sort' might not be defined at runtime.
org/org.el:8765:17: Warning: the function `cl-remove-if' might not be defined at runtime.
org/org.el: Warning: the function `cl-find-if' might not be defined at runtime.
org/org.el:5306:19: Warning: the function `rx-to-string' might not be defined at runtime.
org/org.el:4695:29: Warning: the function `url-retrieve-synchronously' might not be defined at runtime.
org/org.el:821:19: Warning: the function `cl-remove-if-not' might not be
defined at runtime.
In end of data:
progmodes/cperl-mode.el:6897:15: Warning: the function `visit-tags-table-buffer' might not be defined at runtime.
progmodes/cperl-mode.el:6379:12: Warning: the function `info' might not be defined at runtime.
progmodes/cperl-mode.el:1267:6: Warning: the function `rx-to-string' might not be defined at runtime.


etc.

Could this be related to Stefan's function defalias chain thing that
went in earlier today?  Stefan?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master df49e3a3ab 3/3: Merge branch 'master' of /home/acm/emacs/emacs.git/master

[Stefan Monnier]

> Could this be related to Stefan's function defalias chain thing that
> went in earlier today?  Stefan?

Looks like it, yes.


        Stefan

Re: master df49e3a3ab 3/3: Merge branch 'master' of /home/acm/emacs/emacs.git/master

[Alan Mackenzie]

Hello, Lars.

On Mon, Jan 31, 2022 at 19:51:44 +0100, Lars Ingebrigtsen wrote:
> Alan Mackenzie <acm@muc.de> writes:

> > Would you please try out the following, and confirm that it works.  Then
> > I'll commit it to master.  Though, come to think of it, it could
> > probably do with a line break.

> Thanks; I can confirm that with "git clean -xf; make" I don't get any of
> those errors, so please go ahead and push.

Have done so.  I think we can chalk up this bug as fixed, now.

[ .... ]

> -- 
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: master df49e3a3ab 3/3: Merge branch 'master' of /home/acm/emacs/emacs.git/master

[Stefan Monnier]

> But I'm seeing some warnings in the build now that I think probably are
> totally unrelated to this stuff --
[...]
> Could this be related to Stefan's function defalias chain thing that
> went in earlier today?  Stefan?

Should be fixed now,


        Stefan

Re: master df49e3a3ab 3/3: Merge branch 'master' of /home/acm/emacs/emacs.git/master

[Lars Ingebrigtsen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Should be fixed now,

Yup; the warnings are gone now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no