From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#55156: [PATCH] eval.c: New functions `defvar-f` and `defconst-f` Date: Wed, 27 Apr 2022 21:29:34 -0400 Message-ID: References: <87tuaep47a.fsf@gnus.org> <87pml2p35g.fsf@gnus.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40420"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 55156@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 28 03:31:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1njszx-000AJ0-Ia for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Apr 2022 03:31:13 +0200 Original-Received: from localhost ([::1]:35652 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njszw-0007oR-9K for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 27 Apr 2022 21:31:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60412) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njszm-0007oI-Tr for bug-gnu-emacs@gnu.org; Wed, 27 Apr 2022 21:31:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50879) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njszm-0002uL-Ko for bug-gnu-emacs@gnu.org; Wed, 27 Apr 2022 21:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1njszm-00067K-Gu for bug-gnu-emacs@gnu.org; Wed, 27 Apr 2022 21:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Apr 2022 01:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55156 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55156-submit@debbugs.gnu.org id=B55156.165110940223351 (code B ref 55156); Thu, 28 Apr 2022 01:31:02 +0000 Original-Received: (at 55156) by debbugs.gnu.org; 28 Apr 2022 01:30:02 +0000 Original-Received: from localhost ([127.0.0.1]:44775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njsyf-00063y-1u for submit@debbugs.gnu.org; Wed, 27 Apr 2022 21:30:02 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:30935) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njsyZ-00063j-PO for 55156@debbugs.gnu.org; Wed, 27 Apr 2022 21:29:51 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id ADB0010027D; Wed, 27 Apr 2022 21:29:41 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 7E6371000C4; Wed, 27 Apr 2022 21:29:39 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1651109379; bh=h+K0L0FSWJdWdRqs+HkIk55KhJR/sFH82Drn7GFeKug=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=mKIDkETO03bmkmmUbbS4OBEPlX4Nxj/SmQyBRzmB0Mm7mLNhcxymv5Iy4Za7xuOtC CH1XJF6F8L5sNI7pCuCEVQY0ZqKRDCGWI/M2UlskYxfpbjO0tIcgc6TUt2x6VzpwDt ltnbQzhTAYvc35uKfdJOgb60u/ckKuDMl96bqEtJm+TzAc4ivZOihEGBslTZDBXbtF 6V7OIojbvKWNf/4usKhgzQfHWjm5RjsVAzQN/hOVDtHHiguGSqzlTu5l3trzga9G5/ /GlKlkpPr835yevULyz+7FxgGRuqDZ0uEZIuOxMo+pF9e8nnxzWRTEfQgkv5r5IevW D4z6U/4+P9afw== Original-Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 441971205E3; Wed, 27 Apr 2022 21:29:39 -0400 (EDT) In-Reply-To: <87pml2p35g.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 28 Apr 2022 00:33:47 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:230824 Archived-At: >> Try: >> >> (let ((f (byte-compile >> '(lambda (x) >> (defvar sm-x (progn (message "hello %S" x) x)))))) >> (funcall f 5) >> (funcall f 6)) >> >> and check *Messages* :-( > > Oh, if we call a function containing the defvar... Yes, that's probably > rare enough that nobody's noticed. > > I tried to byte-compile a file and just load the .elc a few times, and > the message was only done once: > > (defvar this-thing (message "hello")) Duh, I forgot about the toplevel special case, indeed. OK, now it makes sense. >> If we prefer keeping the behavior we currently promise, we can of course >> do that (just change `defvar-f` so it takes a function of no argument as >> second arg, it makes the generated code (and the C code) a bit less >> simple, but it's no worse than what we currently have). > I think I'd prefer keeping the behaviour we currently promise, So do I. I'll see about updating the patch. Stefan