From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: Lars Ingebrigtsen <larsi@gnus.org>
Subject: Re: master f515d658e5 1/2: Don't quote numbers in byte-run--set-*
Date: Fri, 17 Jun 2022 13:58:17 -0400 [thread overview]
Message-ID: <jwviloz5g7g.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20220617171130.8EDECC01685@vcs2.savannah.gnu.org> (Lars Ingebrigtsen's message of "Fri, 17 Jun 2022 13:11:30 -0400 (EDT)")
> (defalias 'byte-run--set-doc-string
> #'(lambda (f _args pos)
> (list 'function-put (list 'quote f)
> - ''doc-string-elt (list 'quote pos))))
> + ''doc-string-elt (if (numberp pos)
> + pos
> + (list 'quote pos)))))
Should we push this one a step further, as below?
> (defalias 'byte-run--set-indent
> #'(lambda (f _args val)
> (list 'function-put (list 'quote f)
> - ''lisp-indent-function (list 'quote val))))
> + ''lisp-indent-function (if (numberp val)
> + val
> + (list 'quote val)))))
Doing the same here would sadly break too much existing code.
Stefan
diff --git a/lisp/emacs-lisp/byte-run.el b/lisp/emacs-lisp/byte-run.el
index dd90bcf4d82..140a1d765d5 100644
--- a/lisp/emacs-lisp/byte-run.el
+++ b/lisp/emacs-lisp/byte-run.el
@@ -217,9 +217,7 @@ 'byte-run--set-doc-string
(defalias 'byte-run--set-indent
#'(lambda (f _args val)
(list 'function-put (list 'quote f)
- ''lisp-indent-function (if (numberp val)
- val
- (list 'quote val)))))
+ ''lisp-indent-function val))))
(defalias 'byte-run--set-speed
#'(lambda (f _args val)
diff --git a/lisp/emacs-lisp/cl-generic.el b/lisp/emacs-lisp/cl-generic.el
index 200af057cd7..b1579a61fe5 100644
--- a/lisp/emacs-lisp/cl-generic.el
+++ b/lisp/emacs-lisp/cl-generic.el
@@ -545,7 +545,7 @@ cl-defmethod
\(and can be extended) by the various methods of `cl-generic-generalizers'.
\(fn NAME [EXTRA] [QUALIFIER] ARGS &rest [DOCSTRING] BODY)"
- (declare (doc-string cl--defmethod-doc-pos) (indent defun)
+ (declare (doc-string #'cl--defmethod-doc-pos) (indent defun)
(debug
(&define ; this means we are defining something
[&name [sexp ;Allow (setf ...) additionally to symbols.
next parent reply other threads:[~2022-06-17 17:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <165548588979.10920.4402229762078749924@vcs2.savannah.gnu.org>
[not found] ` <20220617171130.8EDECC01685@vcs2.savannah.gnu.org>
2022-06-17 17:58 ` Stefan Monnier [this message]
2022-06-17 18:01 ` master f515d658e5 1/2: Don't quote numbers in byte-run--set-* Stefan Monnier
2022-06-17 18:08 ` Lars Ingebrigtsen
2022-06-17 18:20 ` Stefan Monnier
2022-06-18 11:32 ` Lars Ingebrigtsen
2022-06-18 13:34 ` Stefan Monnier
2022-06-19 11:10 ` Lars Ingebrigtsen
2022-06-19 12:57 ` Basil L. Contovounesios
2022-06-19 13:15 ` Lars Ingebrigtsen
2022-06-19 16:19 ` Michael Heerdegen
2022-06-19 22:30 ` Lars Ingebrigtsen
2022-06-19 22:24 ` Stefan Monnier
2022-06-19 22:29 ` Lars Ingebrigtsen
2022-06-19 23:12 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwviloz5g7g.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.