From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Special Event: Davin reveals his own personal additions to Emacs. Date: Tue, 12 Jul 2022 23:08:50 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27417"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel To: Davin Pearson Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jul 13 05:09:58 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oBSlB-0006sb-HV for ged-emacs-devel@m.gmane-mx.org; Wed, 13 Jul 2022 05:09:57 +0200 Original-Received: from localhost ([::1]:55808 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oBSlA-0008DK-AX for ged-emacs-devel@m.gmane-mx.org; Tue, 12 Jul 2022 23:09:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35292) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oBSkF-0007Hq-Ib for emacs-devel@gnu.org; Tue, 12 Jul 2022 23:08:59 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:27617) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oBSkC-0003gZ-RA for emacs-devel@gnu.org; Tue, 12 Jul 2022 23:08:58 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id E539A100280; Tue, 12 Jul 2022 23:08:54 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 084CA1001CB; Tue, 12 Jul 2022 23:08:53 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1657681733; bh=61B2Z75ANYgsKrPDgmhB2QWS4F3ioYPwBAsWfS/ocIM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=hzNZfsBNl+LFx15efW/z67CUt1jgzjiHNiPz5kuISvy717TIurql0O1iO3GYo1ovs +hqYUJDeVBGT0S6XAYeJ7WEJhH8P6Nz6SszXW0WvToxWG6YLxmN+q4/MiAULxHdvyz 7ooLhrPBPzEdau3Fa9doDJRJV+83iwPcKXFrECf0dlEMQDZlR/ZTMaTu2Kzb91RPqe YenpmJGkabGv+xxE53E1RFf08rM6Ct9OJOnchF9G8tsmuxZ0EXUM8cXss6FLo7TPvc YqGaP+pXh0KI+lrzXoKgWskpAEgGmR+u4wkYxjRxVSOlVkwFJCpUmOr5OCgtOaX2FO Utgx1BDzTn60A== Original-Received: from pastel (unknown [45.72.196.165]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BF0EE120102; Tue, 12 Jul 2022 23:08:52 -0400 (EDT) In-Reply-To: (Davin Pearson's message of "Wed, 13 Jul 2022 10:35:55 +1200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292100 Archived-At: >> Parenthesis shall end together, not like this: >> >> (defun manifest--log-message (msg) >> (save-excursion >> (set-buffer manifest--buffer) >> (goto-char (point-max)) >> (setq latest-file (manifest--get-latest-file)) >> (insert msg "\n") >> ) >> ) >> >> rather like: >> >> (defun manifest--log-message (msg) >> (save-excursion >> (set-buffer manifest--buffer) >> (goto-char (point-max)) >> (setq latest-file (manifest--get-latest-file)) >> (insert msg "\n"))) I dislike those close-parens-on-their-own-lines as well, but more importantly: - should use `with-current-buffer`. - should not `setq` on a global variable that doesn't have an appropriate namespace prefix. Stefan