From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Davin Pearson <davin.pearson@gmail.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Special Event: Davin reveals his own personal additions to Emacs.
Date: Tue, 12 Jul 2022 23:08:50 -0400 [thread overview]
Message-ID: <jwvilo11zjp.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CAG9ihEuX4htXDw=j9dkOh5Y-60hZcLrB07V83az-ZtKMbf0uNw@mail.gmail.com> (Davin Pearson's message of "Wed, 13 Jul 2022 10:35:55 +1200")
>> Parenthesis shall end together, not like this:
>>
>> (defun manifest--log-message (msg)
>> (save-excursion
>> (set-buffer manifest--buffer)
>> (goto-char (point-max))
>> (setq latest-file (manifest--get-latest-file))
>> (insert msg "\n")
>> )
>> )
>>
>> rather like:
>>
>> (defun manifest--log-message (msg)
>> (save-excursion
>> (set-buffer manifest--buffer)
>> (goto-char (point-max))
>> (setq latest-file (manifest--get-latest-file))
>> (insert msg "\n")))
I dislike those close-parens-on-their-own-lines as well, but more
importantly:
- should use `with-current-buffer`.
- should not `setq` on a global variable that doesn't have an appropriate
namespace prefix.
Stefan
next prev parent reply other threads:[~2022-07-13 3:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-10 3:39 Special Event: Davin reveals his own personal additions to Emacs Davin Pearson
2022-07-10 8:56 ` Philip Kaludercic
2022-07-12 23:20 ` Davin Pearson
2022-07-10 11:45 ` Jean Louis
2022-07-12 22:35 ` Davin Pearson
2022-07-13 3:08 ` Stefan Monnier [this message]
2022-07-13 22:57 ` Davin Pearson
2022-07-14 1:47 ` Stefan Monnier
2022-07-14 2:30 ` Davin Pearson
2022-07-14 4:42 ` Davin Pearson
2022-07-14 14:13 ` Stefan Monnier
2022-07-10 12:57 ` Stefan Monnier
2022-07-10 16:03 ` Document that symbol prefix "my-" (or other) should be left for users Teemu Likonen
2022-07-10 16:59 ` Stefan Kangas
2022-07-10 18:11 ` Bozhidar Batsov
2022-07-10 19:20 ` Tim Cross
2022-07-11 3:17 ` Richard Stallman
2022-07-10 18:22 ` Special Event: Davin reveals his own personal additions to Emacs Clément Pit-Claudel
2022-07-10 19:50 ` Rudolf Adamkovič
2022-07-17 1:43 ` Davin Pearson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvilo11zjp.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=davin.pearson@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.