From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Searching for line beginning Date: Sun, 14 Aug 2022 13:24:31 -0400 Message-ID: References: <831qtkm9ni.fsf@gnu.org> <878rnqq1qr.fsf@tcd.ie> <83pmh2kfaj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28036"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: "Basil L. Contovounesios" , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Aug 14 19:25:54 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oNHN4-000753-6R for ged-emacs-devel@m.gmane-mx.org; Sun, 14 Aug 2022 19:25:54 +0200 Original-Received: from localhost ([::1]:51606 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oNHN2-0005lr-Jo for ged-emacs-devel@m.gmane-mx.org; Sun, 14 Aug 2022 13:25:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40164) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNHLt-00054v-95 for emacs-devel@gnu.org; Sun, 14 Aug 2022 13:24:41 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:42003) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNHLn-00037d-Dc; Sun, 14 Aug 2022 13:24:40 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id DEC95100134; Sun, 14 Aug 2022 13:24:33 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 9629F10008C; Sun, 14 Aug 2022 13:24:32 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1660497872; bh=/q1jU0TSRHwmn2Q2dTRqSyDWFHHPDFYmiqel2FWkSv4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=PQYFo3/n1gVnFU8+CVzOcaTAOersbL+pGlpai1rQZyfV8V9quRyiBrte1s+SDJPMs Udp0tzpihDDNZEmo/CVCIib7We8KqS7SwH5WlFQYfOr+NPZpHzlx6Kl7wB8rUZJP/L WMbIZc8jEMlKPdZ1RsweDjiaJZ4WjiXA4Nj4EoV+AW14qIwrVGD4F9K2rPlvckKF/5 w1mWkbCFCVb1SfLBGoZ+haX9+DVU4FufvoYIsKw4WwokWF8i4airEnHGGN5Iwn7BMH IaVD3523XQu/OKFDqBVdgcWj9Ar8OMq18uJP8xkXHwiAaHRE5G1xXpH7XfiYsVmYPz OaQUOg5MHMUpQ== Original-Received: from pastel (unknown [45.72.195.111]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5865C120228; Sun, 14 Aug 2022 13:24:32 -0400 (EDT) In-Reply-To: <83pmh2kfaj.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 14 Aug 2022 18:36:52 +0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:293453 Archived-At: Eli Zaretskii [2022-08-14 18:36:52] wrote: >> From: "Basil L. Contovounesios" >> Cc: emacs-devel@gnu.org >> Date: Sun, 14 Aug 2022 18:33:00 +0300 >> >> Eli Zaretskii [2022-08-13 18:43 +0300] wrote: >> >> > C-a (move-beginning-of-line) does this to find the line's beginning: >> > >> > ;; Move to beginning-of-line, ignoring fields and invisible text. >> > (skip-chars-backward "^\n") >> > (while (and (not (bobp)) (invisible-p (1- (point)))) >> > (goto-char (previous-char-property-change (point))) >> > (skip-chars-backward "^\n")) >> > >> > Apart of the fields part (which can be handled by binding >> > inhibit-field-text-motion), can anyone see a reason why not use >> > line-beginning-position instead? The latter is much faster, >> > especially when lines are very long. >> >> FWIW, one could also say (beginning-of-line) or (beginning-of-line 1) >> instead of (goto-char (line-beginning-position)). > > As a matter of principle, I don't like calling commands from Lisp if I > can avoid that, because commands frequently have extensive checks of > the arguments that are redundant in non-interactive calls. I also like to avoid moving point when it's possible/easy (my original motivation was to avoid the extra tricky semantics of moving point in the presence of things like `point-entered` and `intangible` properties, but even with `inhibit-point-motion-hooks` permanently set to t I think it's preferable not to move point when given the choice). In the above loop, it seems it's easy not to move point. Stefan