From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#56682: locked narrowing Date: Wed, 17 Aug 2022 15:18:57 -0400 Message-ID: References: <5e3c3081-f098-8140-c767-b895c32bf30b@yandex.ru> <835yisffil.fsf@gnu.org> <831qtgff78.fsf@gnu.org> <83zgg4dw4y.fsf@gnu.org> <83r11gdrr4.fsf@gnu.org> <83edxfds7s.fsf@gnu.org> <83r11fc80o.fsf@gnu.org> <83o7wjc6o2.fsf@gnu.org> <83lernc5gu.fsf@gnu.org> <83k076dd7d.fsf@gnu.org> <83czcyd8jf.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33312"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 56682@debbugs.gnu.org, gregory@heytings.org, dgutov@yandex.ru To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 17 21:20:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oOOaJ-0008RP-GZ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Aug 2022 21:20:11 +0200 Original-Received: from localhost ([::1]:34698 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oOOaH-0004RK-FH for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Aug 2022 15:20:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59618) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oOOaA-0004RB-QW for bug-gnu-emacs@gnu.org; Wed, 17 Aug 2022 15:20:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35101) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oOOaA-0002l1-I7 for bug-gnu-emacs@gnu.org; Wed, 17 Aug 2022 15:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oOOaA-0002xS-ES for bug-gnu-emacs@gnu.org; Wed, 17 Aug 2022 15:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Aug 2022 19:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56682 X-GNU-PR-Package: emacs Original-Received: via spool by 56682-submit@debbugs.gnu.org id=B56682.166076395311282 (code B ref 56682); Wed, 17 Aug 2022 19:20:02 +0000 Original-Received: (at 56682) by debbugs.gnu.org; 17 Aug 2022 19:19:13 +0000 Original-Received: from localhost ([127.0.0.1]:53074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oOOZN-0002vu-6r for submit@debbugs.gnu.org; Wed, 17 Aug 2022 15:19:13 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:53919) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oOOZI-0002ve-Pm for 56682@debbugs.gnu.org; Wed, 17 Aug 2022 15:19:12 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 716FE44259F; Wed, 17 Aug 2022 15:19:01 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 3E5FB44259A; Wed, 17 Aug 2022 15:19:00 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1660763940; bh=izsvuVwiIO+1hZ87Gt7qmlYTozvwMYFHYzfpPS5+uac=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=O71juFPsnoNTuzI+feIUnEIRvKIRXar2sHjsb4gjsozgt9IWVMFaXjfnKUIU4Urul a9sf8OtsP+sdS2pxmKA8nsKptH9AfMpOvsaU4TsIoZkpqa0qJkDdseyGDLT2GrzSLC g7/rLZuZt3sZbdIw9tvp/7BDpSzqU2qCy6QulFJyU20rowGc3kb2PBlA5U0/yjDPDw W5r0Gkq4vI8zfSPgboOyMAmXhiDdGJ4vX7J5Z/qih+7u3ycc3sbkHKcWdUKVlqexoa B2sLjDMxb66ZmdmNKOaAINtRyeh4wFPiDOZq50mpp7mbnF+Hw0X1AOuFWogB7SZphp slKKjHRsfXu7g== Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 29B731202E6; Wed, 17 Aug 2022 15:19:00 -0400 (EDT) In-Reply-To: <83czcyd8jf.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 17 Aug 2022 21:33:40 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240106 Archived-At: > Search in xdisp.c for "->base_line_number = 0", and you will see that > we invalidate the cache when the narrowing changes or when other > similar calamities happen. OK, after another search I found (in `redisplay_window` and `try_scrolling`) that we do: if (!just_this_one_p || current_buffer->clip_changed || BEG_UNCHANGED < CHARPOS (startp)) /* Forget any recorded base line for line number display. */ w->base_line_number = 0; So IIUC `w->base_line_number` can be used if: w->base_line_number != 0 && !current_buffer->clip_changed && BEG_UNCHANGED < w->base_line_pos ? Why do we flush the cache when `just_this_one_p` is false? Stefan