From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 09b5f00613: ; Fix calls to treesit functions Date: Sun, 18 Dec 2022 18:54:01 -0500 Message-ID: References: <167138365421.15060.2886694741391315956@vcs2.savannah.gnu.org> <20221218171414.77B8EC0060F@vcs2.savannah.gnu.org> <47D9ABEB-EA9C-49DA-BC35-189A563DEC10@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14535"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org, Eli Zaretskii To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 19 00:54:44 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p73US-0003bf-IZ for ged-emacs-devel@m.gmane-mx.org; Mon, 19 Dec 2022 00:54:44 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p73Tt-0003lu-4f; Sun, 18 Dec 2022 18:54:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p73Tr-0003lS-Q3 for emacs-devel@gnu.org; Sun, 18 Dec 2022 18:54:07 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p73Tq-0003Z8-Cq; Sun, 18 Dec 2022 18:54:07 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id C9FBE1008C9; Sun, 18 Dec 2022 18:54:04 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 426AB100809; Sun, 18 Dec 2022 18:54:03 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1671407643; bh=1TiPKo9cDCFJj9szPEUgRvq1IMxLGEP0rbOtnU4dl/Q=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=HmAk4gR5R/UYQzRyI2NmGC2dKcxq86YBQ+zbkfvXg3RH5kqtfjjjw3EAXbiLXoQM0 Zyexfw46cMlo6Euzk6ZQCIvNu8v78rq7onZTL6BaIv8HfVBJ9vfVySzuJAnDxlSBgF OHT6Kgld4HYc0AIuco9nP4tMaXToj8049PNn2wZ7VEUutP9iBkEt9n8vdhN6DUw24O qq3gyLNb2MFWbrX4YvDM00AOm/5+SLne3gHKn3ZTjWoFR38MG9qbFF2UUv2bCyxfnJ dv5xoygZxbRV+CfbKamoqgBEVKsShLxSx+nO6rRnzvsZCSBbpoSdoniKVjPBJt1hgI AERUtkhKXCrGQ== Original-Received: from pastel (unknown [45.72.200.228]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1300C120409; Sun, 18 Dec 2022 18:54:03 -0500 (EST) In-Reply-To: <47D9ABEB-EA9C-49DA-BC35-189A563DEC10@gmail.com> (Yuan Fu's message of "Sun, 18 Dec 2022 15:02:14 -0800") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301623 Archived-At: > That makes sense. Also, anyone using tree-sitter functions needs to > declare functions in treesit.c in case Emacs didn=E2=80=99t build with > tree-sitter. Should we streamline it with a macro like this? I wouldn't bother. > (eval-when-compile > (require 'treesit) > (treesit-declare-c-functions)) `declare-function` within a `eval-when-compile` (just like (defvar )) is a bad idea. If it works, it's only by accident and can be considered a bug (which could get fixed). Stefan