From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master a30781399b3: * subr-x (eval-command-interactive-spec): New function. Date: Wed, 14 Jun 2023 16:52:37 -0400 Message-ID: References: <168595059426.2523.2109338263713299231@vcs2.savannah.gnu.org> <20230605073635.19060C00613@vcs2.savannah.gnu.org> <875y80g7p8.fsf@melete.silentflame.com> <87fs6u5p1r.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30436"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Sean Whitton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 14 22:53:27 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q9XUc-0007kG-U4 for ged-emacs-devel@m.gmane-mx.org; Wed, 14 Jun 2023 22:53:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q9XTv-0004qM-8O; Wed, 14 Jun 2023 16:52:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9XTt-0004qE-Nc for emacs-devel@gnu.org; Wed, 14 Jun 2023 16:52:41 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9XTs-0008I1-95 for emacs-devel@gnu.org; Wed, 14 Jun 2023 16:52:41 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 1C9F8801D6; Wed, 14 Jun 2023 16:52:39 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id D63F580491; Wed, 14 Jun 2023 16:52:37 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1686775957; bh=7DTJrsNFave0CSF/LyhwUKdgLsi9FfivPpaPSoNeINI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=b46k3j7RX7mZRxjyHdmrJj7q2jg8sOK1aCI6YbIMWsuXBXL4e9hNoBgLnxX1u8CRq 4W0AqaXMVwGaXZ/cutSDOQe7sjYIsSSfqxfulau5Ee/s+qisyHrWyYKylNJJod6Hlf n+l0buN2HOWMGz16jiOsFnGqlv3mdFSmKLn8fv7yKTo85IF//bUjiclnTpqC4IUlJY 0OPd338b8ctlTguEg2HEgwHMN9SdxU0xK3dbPpLRb+skeKrA8V3MjpX4WSBcKyL0As G+BJr/6vrG1YSbSPTo2PDlHstWeD8myCpdXyZXHoo4tuvq8jE6175pj9rsct9QiyZN Z4VDVy21NgKww== Original-Received: from alfajor (modemcable005.21-80-70.mc.videotron.ca [70.80.21.5]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B7870120228; Wed, 14 Jun 2023 16:52:37 -0400 (EDT) In-Reply-To: <87fs6u5p1r.fsf@melete.silentflame.com> (Sean Whitton's message of "Wed, 14 Jun 2023 11:14:08 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306801 Archived-At: >> AFAICT the functionality of `advice-eval-interactive-spec` is not used >> often at all, so having a specialized version for the specific case when >> it's applied to (cadr (interactive-form command)) seems hard to justify. >> >> Can you point to (potential) users? > > Here is something I have: > > (defun spw/run-or-restore-gud (arg) > (interactive "P") > (if (or arg (not (and (bound-and-true-p gud-comint-buffer) > (get-buffer-process gud-comint-buffer)))) > ;; Start a new debugging session even if one already exists. > ;; Killing `gud-comint-buffer' is the documented way to quit an > ;; existing session. > (let* ((cmd (cl-case major-mode > (c-mode 'gdb) (cperl-mode 'perldb) (python-mode 'pdb) > (t (intern (completing-read "GUD command: " > '(gdb perldb pdb) nil t))))) > (args (eval-command-interactive-spec cmd))) > (when (buffer-live-p gud-comint-buffer) > (when-let ((proc (get-buffer-process gud-comint-buffer))) > (set-process-query-on-exit-flag proc nil)) > (kill-buffer gud-comint-buffer)) > (gdb-wait-for-pending (lambda () (apply cmd args)))) > ;; Restore the session. > (cl-case (buffer-local-value 'gud-minor-mode gud-comint-buffer) > (gdbmi (gdb-restore-windows) > ;; Try to ensure prompt is at the bottom of its window. > (recenter (window-body-height))) > (t (pop-to-buffer gud-comint-buffer))))) > > I initially tried implementing this using :around advice, but found that > worked less well in some respect that I can now not remember. > But I definitely tried it :) OK, so that's one example. Any other? Because, to me, a single use-case doesn't seem to justify the definition of a one-liner helper function. [ Especially since that helper function is still not a faithful simulation of what happens in a "normal" execution of the command and fixing that wrinkle will likely require changing the API :-( ] Stefan