From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: package-autosuggest Date: Wed, 30 Aug 2023 19:13:48 -0400 Message-ID: References: <87il9kksqz.fsf@dfreeman.email> <4874df51-9652-f9fd-0576-9dd6a4cba31a@gutov.dev> <3d5ef276-ce6b-9ff0-0c60-1da6b887b365@gutov.dev> <1070e416-2a13-49e0-90d4-fbc526cd461c@app.fastmail.com> <83ttskia84.fsf@gnu.org> <97c96b72-ebba-4853-98d2-86e3ba8bbc05@app.fastmail.com> <83sf84i9ix.fsf@gnu.org> <837cpfhzdm.fsf@gnu.org> <83zg2agjp8.fsf@gnu.org> <87ttshk3ns.fsf@posteo.net> <83il8whjig.fsf@gnu.org> <87fs40oiie.fsf@posteo.net> <838r9shgtz.fsf@gnu.org> <871qfkogy7.fsf@posteo.net> <835y4whd0m.fsf@gnu.org> <87r0nks55d.fsf_-_@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3242"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , stefankangas@gmail.com, yandros@gmail.com, bozhidar@batsov.dev, dmitry@gutov.dev, rms@gnu.org, danny@dfreeman.email, emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Aug 31 01:14:38 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qbUOT-0000db-SR for ged-emacs-devel@m.gmane-mx.org; Thu, 31 Aug 2023 01:14:38 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbUNq-0003TF-8y; Wed, 30 Aug 2023 19:13:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbUNo-0003T7-K0 for emacs-devel@gnu.org; Wed, 30 Aug 2023 19:13:56 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbUNl-0006N1-2r; Wed, 30 Aug 2023 19:13:56 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 543674455E1; Wed, 30 Aug 2023 19:13:50 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1693437229; bh=wBNIYLKXRJXp0oTpQ9mUa3BoJDcl2PSZVP+5csvlXV8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=A3LGn/38wUYv9zJzEaWSVcdS06M4tvpddyZNicKLH0pwnE2nuMrrmhuMKuhVjIK/V pKaUR6bg0jlNycGZkx52SeMN7GgxgnEJQ2nH1k3fhAqCoEFZvITGFFHe6kzk0ALQAv bdwITQwyRS1Xvw2wDKOYANg44JC85FRD5BsKj9qihIiYP1+ptApqhShUcBd5pwiZaE J4O5TLXEa4ZgF2RTtlEnn9BPTK/SfP9fPjUp2jkzkLCM9WtMBIhiZj/oKnjIKVvyMO b/kKyuS+DmkN9OucZFiZbSZJoTBXRcVu86iCKmcLubQYc392Byk7DgqCat3MH/TvLo uMNiHI0vmu8Yg== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id EA28F4455CD; Wed, 30 Aug 2023 19:13:48 -0400 (EDT) Original-Received: from pastel (69-196-154-197.dsl.teksavvy.com [69.196.154.197]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A18F41202D5; Wed, 30 Aug 2023 19:13:48 -0400 (EDT) In-Reply-To: <87r0nks55d.fsf_-_@posteo.net> (Philip Kaludercic's message of "Wed, 30 Aug 2023 19:26:38 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:309566 Archived-At: > +(defun package--suggestion-applies-p (pkg-sug) > + "Check if a suggestion PKG-SUG is applicable to the current buffer." > + (pcase pkg-sug > + (`(,(pred package-installed-p) . _) nil) I think we should strive to minimize the dependency on `package.el` (as well as the performance impact) so we should try and use something like `fboundp` here instead (testing "the function" provided by the package when it's installed). Stefan