From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#63916: 30.0.50; use-package: changes do not propagate to elpa-devel Date: Fri, 08 Sep 2023 15:35:04 -0400 Message-ID: References: <4b1ff1660351348f3d5f1bc848965d59@orthen.net> <874jnf3d0c.fsf@posteo.net> <87wn0a2sp8.fsf@posteo.net> <87fs6y6jkq.fsf@posteo.net> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26152"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Philip Kaludercic , 63916@debbugs.gnu.org To: Benjamin Orthen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 08 21:36:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qehHB-0006YS-Iu for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 Sep 2023 21:36:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qehGs-00060A-3H; Fri, 08 Sep 2023 15:36:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qehGq-0005zn-J9 for bug-gnu-emacs@gnu.org; Fri, 08 Sep 2023 15:36:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qehGq-0002Ey-9l for bug-gnu-emacs@gnu.org; Fri, 08 Sep 2023 15:36:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qehGs-0003F0-Dm for bug-gnu-emacs@gnu.org; Fri, 08 Sep 2023 15:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Sep 2023 19:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63916 X-GNU-PR-Package: emacs Original-Received: via spool by 63916-submit@debbugs.gnu.org id=B63916.169420173912427 (code B ref 63916); Fri, 08 Sep 2023 19:36:02 +0000 Original-Received: (at 63916) by debbugs.gnu.org; 8 Sep 2023 19:35:39 +0000 Original-Received: from localhost ([127.0.0.1]:45657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qehGH-0003EA-VQ for submit@debbugs.gnu.org; Fri, 08 Sep 2023 15:35:39 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:43013) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qehGC-0003Dq-AC for 63916@debbugs.gnu.org; Fri, 08 Sep 2023 15:35:24 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 075A310009E; Fri, 8 Sep 2023 15:35:12 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1694201706; bh=lvtw9odQlwb6qQJyUztuc/ngaZxKYywlrRuG8RUJFvA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ZxDoMqg7p+kkqc6KgtLDLIFCa92Hd8u/cf+jwk+k95JfU/GNvgFLkFtw/Jsz04BOA FoN43FDgQYd0VnwqJTuINF5wqg33P7dr0PfQZ+dfud6lAjpSlKZU4rzb7e+K6/ahnh hbCbz/JfclTFGlFauCP/23OqboeFY+4p79b3VmBco8q+FAOWKHI7fZNpJko+WNRdUZ pW9S+Z2T9sIc1ohEy6m0C+4iRh+W45jl6FvNX3FojAXaCqgoecQw7a2oc+Jrg/jd2U UqDXBWAiGOf7QqobfDypfnXkRb+9sI2Rka6XsroJRLZDGEuZNKabcNUEB1We0AJvh5 w1W7IuS8/4R6g== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 595D9100064; Fri, 8 Sep 2023 15:35:06 -0400 (EDT) Original-Received: from pastel (unknown [104.247.229.91]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 35A80120370; Fri, 8 Sep 2023 15:35:06 -0400 (EDT) In-Reply-To: (Benjamin Orthen's message of "Fri, 08 Sep 2023 12:55:38 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269818 Archived-At: Hi, > Instead of looking only at the git log of the main package file, we > look instead at the git log of all files of the core package. > This way, a new devel version is created when any other package file is > changed, not just the main file. It has a minor downside which is that it slows down the overwhelming cases (where there are no changes), but it's probably lost in the noise, so it sounds like a very good idea, thank you. > Is this the right mailing list to send the patch? Yes. [ BTW, Philip's `list-ensure` is called `ensure-list` :-) And yes, I think it's OK to use functionality from Emacs-28. ] >+ (when-let >+ ((core (elpaa--spec-get pkg-spec :core))) AFAICT this code is only used when `:core` is non-nil, so better either not test for it redundantly, or do it via `cl-assert`. >+ (unless (member item excludes) The code looks generally good, but I'm not sure about the one line above: - I know it won't do the right thing for ERC's "lisp/erc/ChangeLog.*" but it's probably harmless (those files basically never change anyway). - I have the impression that it won't do the right thing for `use-package`'s "bind-key.el" Also, I see you do (concat item file) but you only know that `item` is a directory, not that it ends with a `/`. Better use `file-name-concat`. Last but not least: I think this doesn't quite qualify as "trivial" so we'd need you to sign the copyright paperwork (well, maybe with some of the suggested simplifications, it could qualify as "trivial", but it's easier if you sign the paperwork so we don't have to worry about it, especially if you ever submit more code, which I hope you will). To that end, please fill the form below and email it to the FSF as instructed so they can send you the appropriate paperwork to sign. Stefan Please email the following information to assign@gnu.org, and we will send you the assignment form for your past and future changes. Please use your full legal name (in ASCII characters) as the subject line of the message. ---------------------------------------------------------------------- REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES [What is the name of the program or package you're contributing to?] Emacs [Did you copy any files or text written by someone else in these changes? Even if that material is free software, we need to know about it.] [Do you have an employer who might have a basis to claim to own your changes? Do you attend a school which might make such a claim?] [For the copyright registration, what country are you a citizen of?] [What year were you born?] [Please write your email address here.] [Please write your postal address here.] [Which files have you changed so far, and which new files have you written so far?]