From: Stefan Monnier via Users list for the GNU Emacs text editor <help-gnu-emacs@gnu.org>
To: help-gnu-emacs@gnu.org
Subject: Re: Run `window-configuration-change-hook` in Lisp code?
Date: Fri, 08 Nov 2024 09:12:46 -0500 [thread overview]
Message-ID: <jwviksx25ib.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: 5193f2dd-05ca-4a92-a3f9-2a069b8ad72e@jamescherti.com
> The workaround to fix this issue is to call the following after the text
> scale is changed (run-hooks 'window-configuration-change-hook)
From where?
The way I see it, another workaround is for those packages which depend
strongly on such single-size monospace text to add the relevant function
to `text-scale-mode-hook`.
> OP wants to know whether it is good practice or bad practice to run the
> `window-configuration-change-hook` hooks from a third-party package in this
> situation, as a workaround to resolve the issue described above. (Check:
> https://codeberg.org/joostkremers/visual-fill-column/pulls/16 ).
I'd put it in the bad practice column (especially since that hook
is documented to be run in a fairly special way which `run-hooks`
doesn't follow).
Then again, looking at that patch I can't understand why it would work.
Does it work? If so how? That code is run only when `visual-fill-mode`
is enabled, AFAICT, so whether it runs
`window-configuration-change-hook` won't make any difference when
text-scale is used.
Stefan
next prev parent reply other threads:[~2024-11-08 14:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 19:40 Run `window-configuration-change-hook` in Lisp code? Joost Kremers
2024-11-07 4:47 ` Stefan Monnier via Users list for the GNU Emacs text editor
2024-11-07 5:35 ` James Cherti
2024-11-08 14:12 ` Stefan Monnier via Users list for the GNU Emacs text editor [this message]
2024-11-08 14:55 ` Joost Kremers
2024-11-08 17:55 ` Stefan Monnier
2024-11-08 15:51 ` James Cherti
2024-11-08 17:47 ` [External] : " Drew Adams
2024-11-07 7:24 ` Eli Zaretskii
2024-11-07 8:01 ` Joost Kremers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwviksx25ib.fsf-monnier+emacs@gnu.org \
--to=help-gnu-emacs@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.