From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: Emacs-Devel <emacs-devel@gnu.org>
Subject: Re: `q' in debugger with a dedicated *Backtrace* window
Date: Sat, 17 Mar 2007 23:29:30 -0400 [thread overview]
Message-ID: <jwvhcsjz17m.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <BDEIJAFNGDOAGCJIPKPBEEFCCDAA.drew.adams@oracle.com> (Drew Adams's message of "Sat\, 17 Mar 2007 19\:42\:21 -0700")
> (with-current-buffer debugger-buffer
> (erase-buffer)
> (fundamental-mode)
> (with-selected-window (get-buffer-window debugger-buffer 0)
> (when (and (window-dedicated-p (selected-window))
> (not debugger-will-be-back))
> ;; If the window is not dedicated, burying the buffer
> ;; will mean that the frame created for it is left
> ;; around showing some random buffer, and next time we
> ;; pop to the debugger buffer we'll create yet
> ;; another frame.
> ;; If debugger-will-be-back is non-nil, the frame
> ;; would need to be de-iconified anyway immediately
> ;; after when we re-enter the debugger, so iconifying it
> ;; here would cause flashing.
> ;; Use quit-window rather than bury-buffer to quieten
> ;; Drew Adams. --Stef
> (quit-window))))
> To speak to the comment about Drew Adams: Before this was changed to
> quit-window, things were even worse - iconifying (with the flashing
> mentioned) and bury-buffer were tried. Multiple debugger frames were
> created, reproducing like rabbits.
AFAIK, 90% of the flashing problem was fixed by checking
debugger-will-be-back. The 10% remaining is only for the case where
a breakpoint is in the middle of a loop.
As for reproducing like rabbits, this was before the (window-dedicated-p
(selected-window)) check (AFAIK, again), so it's been fixed 100%.
So if I understand correctly you're opposed to bury-buffer because in some
cases it causes flashing. I don't know about you, but I find flashing
*much* less problematic than deletion/recreation of a frame.
You seem to have forgotten the main reason why you didn't want bury-buffer:
you didn't want a iconified frame left around.
I guess I should just revert to bury-buffer to add an option
debugger-for-drew-adams. This way you'll stop whining and I'll get the
saner behavior.
> quit-window is a pain
That's what I told you when you kept begging for it.
Stefan
next prev parent reply other threads:[~2007-03-18 3:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-18 2:42 `q' in debugger with a dedicated *Backtrace* window Drew Adams
2007-03-18 3:29 ` Stefan Monnier [this message]
2007-03-18 7:42 ` Drew Adams
2007-03-18 21:02 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvhcsjz17m.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.