From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Updated project-specific settings patch Date: Mon, 19 May 2008 14:51:02 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1211223111 11839 80.91.229.12 (19 May 2008 18:51:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 19 May 2008 18:51:51 +0000 (UTC) Cc: emacs-devel@gnu.org To: tromey@redhat.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 19 20:52:28 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JyASs-00054J-JC for ged-emacs-devel@m.gmane.org; Mon, 19 May 2008 20:52:06 +0200 Original-Received: from localhost ([127.0.0.1]:55422 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JyAS8-0006sG-Ne for ged-emacs-devel@m.gmane.org; Mon, 19 May 2008 14:51:20 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JyAS4-0006s2-Gh for emacs-devel@gnu.org; Mon, 19 May 2008 14:51:16 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JyAS2-0006rm-W0 for emacs-devel@gnu.org; Mon, 19 May 2008 14:51:16 -0400 Original-Received: from [199.232.76.173] (port=41581 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JyAS2-0006rj-Ot for emacs-devel@gnu.org; Mon, 19 May 2008 14:51:14 -0400 Original-Received: from 206-248-170-48.dsl.teksavvy.com ([206.248.170.48]:51874 helo=ceviche.home) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JyAS2-0002r0-7o for emacs-devel@gnu.org; Mon, 19 May 2008 14:51:14 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 25F8BB422F; Mon, 19 May 2008 14:51:02 -0400 (EDT) In-Reply-To: (Tom Tromey's message of "Mon, 19 May 2008 11:07:48 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:97399 Archived-At: > A long while ago I was working on a patch to allow project-specific > settings for Emacs. Here's the updated version of this patch. > I tried to incorporate all the feedback on previous versions of this > patch into the current patch. In particular: > * Now a patch to files.el, not a separate file. > * Reuses the hack-local-variables code to query the user about risky > settings. > * Search for directory settings is limited to a single file name, > ".dir-settings.el". Thank you. It looks good. I just have a few minor wishes below, but otherwise, feel free to install it. > + (let ((buf (get-buffer-create (if project "*Directory Variabes*" > + "*Local Variables*")))) Better use the same buffer name *Local Variables*. > + ((file-exists-p (concat dir ".dir-settings.el")) > + (setq result (concat dir ".dir-settings.el"))) In most cases, we'd prefer (expand-file-name ".dir-settings.el" dir) over the use of `concat'. The only exception I know is when `dir' is relative and it's important for the result also be relative. One more thing: since we want to include CEDET and CEDET has its own notion of "project data", we want to try and get those two things to converge. So please try and work out with zappo@gnu.org what convergence might look like. Stefan