bug#1848: 23.0.60; isearch-forward fails to find colon characters in Info buffers

bug#1848: 23.0.60; isearch-forward fails to find colon characters in Info buffers

[Brent Goodrick]

Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

1. Invoke Emacs CVS top of trunk on Debian Linux "testing" built as of today (2009-01-10). Pass
the -q option.
2. Type C-h i to view the Info buffer
3. Type d to get to the top node. Insure that there is an "Emacs"
node listed.
4. Type C-s which should be bound to isearch-forward
5. Type e
6. Type m
7. Type a
8. Type c
9. Type s
10. Type :
11. It fails to find the colon character.
12. Rerun the above steps again on Emacs 22-2 and it works as
expected.
13. Back in Emacs 23, copy and paste all of the Info buffer into some
other new scrap buffer, go to the top of the buffer and repeat steps 1
through 10 and it finds the colon.

Can someone double-check that this isn't a symptom of a more serious
change of behavior in isearch or elsewhere in Emacs 23?

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/home/brentg/emacs_from_source/install/share/emacs/23.0.60/etc/DEBUG for instructions.


In GNU Emacs 23.0.60.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.12.11)
 of 2009-01-10 on hungover
Windowing system distributor `The X.Org Foundation', version 11.0.10402000
configured using `configure  '--with-x-toolkit' '--with-xft' '--prefix=/home/brentg/emacs_from_source/install''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  desktop-save-mode: t
  iswitchb-mode: t
  erc-ring-mode: t
  erc-services-mode: t
  erc-networks-mode: t
  display-time-mode: t
  shell-dirtrack-mode: t
  delete-selection-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: 1
  transient-mark-mode: t

Recent input:
<down-mouse-1> <mouse-1> M-x r e p o r b 0 C-g C-h 
i C-s e m a c s : C-p q M-x r e p o r t - e m <tab> 
b u <tab> <return>

Recent messages:
Loading /home/brentg/emacs_lisp/bg-emacs.el (source)...done
Composing main Info directory...done
Desktop: 18 buffers restored.
For information about GNU Emacs and the GNU system, type C-h C-a.
Raising the Emacs window with: DISPLAY=:0.0 wmctrl -a 67109026 -i
Resizing The Emacs window with: DISPLAY=:0.0 wmctrl -r 67109026 -i -b add,maximized_vert,maximized_horz
Quit
Pushed a window configuration. [2 times]
Mark saved where search started
Pushed a window configuration.

bug#1848: 23.0.60; isearch-forward fails to find colon characters in Info buffers

[Juri Linkov]

> 1. Invoke Emacs CVS top of trunk on Debian Linux "testing" built as of
> today (2009-01-10). Pass the -q option.
> 2. Type C-h i to view the Info buffer
> 3. Type d to get to the top node. Insure that there is an "Emacs"
> node listed.
> 4. Type C-s which should be bound to isearch-forward
> 5. Type e
> 6. Type m
> 7. Type a
> 8. Type c
> 9. Type s
> 10. Type :
> 11. It fails to find the colon character.
> 12. Rerun the above steps again on Emacs 22-2 and it works as
> expected.
> 13. Back in Emacs 23, copy and paste all of the Info buffer into some
> other new scrap buffer, go to the top of the buffer and repeat steps 1
> through 10 and it finds the colon.
>
> Can someone double-check that this isn't a symptom of a more serious
> change of behavior in isearch or elsewhere in Emacs 23?

That's correct, in Emacs 23 C-s doesn't find invisible characters
in Info.  This is an intentional change, not a bug.  Please see
http://thread.gmane.org/gmane.emacs.devel/95142

-- 
Juri Linkov
http://www.jurta.org/emacs/

bug#1848: 23.0.60; isearch-forward fails to find colon characters in Info buffers

[Glenn Morris]

Juri Linkov wrote:

> That's correct, in Emacs 23 C-s doesn't find invisible characters
> in Info.  This is an intentional change, not a bug.  Please see
> http://thread.gmane.org/gmane.emacs.devel/95142

I found it a bit confusing that setting search-invisible to t makes no
difference to the behaviour here. Should Info-search-success-function
respect search-invisible?

bug#1848: 23.0.60; isearch-forward fails to find colon characters in Info buffers

[Stefan Monnier]

>> That's correct, in Emacs 23 C-s doesn't find invisible characters
>> in Info.  This is an intentional change, not a bug.  Please see
>> http://thread.gmane.org/gmane.emacs.devel/95142

> I found it a bit confusing that setting search-invisible to t makes no
> difference to the behaviour here. Should Info-search-success-function
> respect search-invisible?

I'd say yes.  Does anyone object?


        Stefan

bug#1848: 23.0.60; isearch-forward fails to find colon characters in Info buffers

[Brent Goodrick]

[-- Attachment #1: Type: text/plain, Size: 549 bytes --]

Sounds reasonable to me.

Brent

On Mon, Jan 12, 2009 at 7:21 AM, Stefan Monnier <monnier@iro.umontreal.ca>wrote:

> >> That's correct, in Emacs 23 C-s doesn't find invisible characters
> >> in Info.  This is an intentional change, not a bug.  Please see
> >> http://thread.gmane.org/gmane.emacs.devel/95142
>
> > I found it a bit confusing that setting search-invisible to t makes no
> > difference to the behaviour here. Should Info-search-success-function
> > respect search-invisible?
>
> I'd say yes.  Does anyone object?
>
>
>        Stefan
>

[-- Attachment #2: Type: text/html, Size: 1076 bytes --]

bug#1848: 23.0.60; isearch-forward fails to find colon characters in Info buffers

[Eli Zaretskii]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Mon, 12 Jan 2009 10:21:48 -0500
> Cc: 1848@emacsbugs.donarmstrong.com, Brent Goodrick <bgoodr@gmail.com>
> 
> >> That's correct, in Emacs 23 C-s doesn't find invisible characters
> >> in Info.  This is an intentional change, not a bug.  Please see
> >> http://thread.gmane.org/gmane.emacs.devel/95142
> 
> > I found it a bit confusing that setting search-invisible to t makes no
> > difference to the behaviour here. Should Info-search-success-function
> > respect search-invisible?
> 
> I'd say yes.  Does anyone object?

I don't object, but wouldn't it be confusing to have it "find" the
colon, without the colon being visible?  Perhaps we should make it
temporarily visible?

bug#1848: 23.0.60; isearch-forward fails to find colon characters in Info buffers

[Stefan Monnier]

>> >> That's correct, in Emacs 23 C-s doesn't find invisible characters
>> >> in Info.  This is an intentional change, not a bug.  Please see
>> >> http://thread.gmane.org/gmane.emacs.devel/95142
>> 
>> > I found it a bit confusing that setting search-invisible to t makes no
>> > difference to the behaviour here. Should Info-search-success-function
>> > respect search-invisible?
>> 
>> I'd say yes.  Does anyone object?

> I don't object, but wouldn't it be confusing to have it "find" the
> colon, without the colon being visible?  Perhaps we should make it
> temporarily visible?

Oh, yes, definitely.  If we can't temporarily show the invisible text,
then we shouldn't obey (eq search-invisible 'open), but we should still
obey (eq search-invisible t).


        Stefan

bug#1848: 23.0.60; isearch-forward fails to find colon characters in Info buffers

[Juri Linkov]

>>> > I found it a bit confusing that setting search-invisible to t makes no
>>> > difference to the behaviour here. Should Info-search-success-function
>>> > respect search-invisible?
>>>
>>> I'd say yes.  Does anyone object?
>
>> I don't object, but wouldn't it be confusing to have it "find" the
>> colon, without the colon being visible?  Perhaps we should make it
>> temporarily visible?
>
> Oh, yes, definitely.  If we can't temporarily show the invisible text,
> then we shouldn't obey (eq search-invisible 'open), but we should still
> obey (eq search-invisible t).

Then the following patch does this.  It checks only for
(eq search-invisible t), not for 'open.

BTW, I'm not sure if we should also skip the breadcrumbs line.
I currently have no problems with the search matching at the
breadcrumbs line.  So maybe we should wait for a request
from someone who has a problem with breadcrumbs.

Index: lisp/info.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/info.el,v
retrieving revision 1.557
diff -c -w -b -r1.557 info.el
*** lisp/info.el	10 Jan 2009 10:42:08 -0000	1.557
--- lisp/info.el	14 Jan 2009 00:59:59 -0000
***************
*** 1868,1878 ****
      (let ((backward (< found beg-found)))
        (not
         (or
  	(if backward
  	    (or (text-property-not-all found beg-found 'invisible nil)
  		(text-property-not-all found beg-found 'display nil))
  	  (or (text-property-not-all beg-found found 'invisible nil)
! 	      (text-property-not-all beg-found found 'display nil)))
  	;; Skip node header line
  	(and (save-excursion (forward-line -1)
  			     (looking-at "\^_"))
--- 1868,1879 ----
      (let ((backward (< found beg-found)))
        (not
         (or
+ 	(and (not (eq search-invisible t))
  	     (if backward
  		 (or (text-property-not-all found beg-found 'invisible nil)
  		     (text-property-not-all found beg-found 'display nil))
  	       (or (text-property-not-all beg-found found 'invisible nil)
! 		   (text-property-not-all beg-found found 'display nil))))
  	;; Skip node header line
  	(and (save-excursion (forward-line -1)
  			     (looking-at "\^_"))

-- 
Juri Linkov
http://www.jurta.org/emacs/

bug#1848: 23.0.60; isearch-forward fails to find colon characters in Info buffers

[Stefan Monnier]

> Then the following patch does this.  It checks only for
> (eq search-invisible t), not for 'open.

Looks fine.

> BTW, I'm not sure if we should also skip the breadcrumbs line.
> I currently have no problems with the search matching at the
> breadcrumbs line.  So maybe we should wait for a request
> from someone who has a problem with breadcrumbs.

I see no reason to skip the breadcrumbs.


        Stefan

bug#1848: marked as done (23.0.60; isearch-forward fails to find colon characters in Info buffers)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 936 bytes --]


Your message dated Thu, 15 Jan 2009 01:18:06 +0200
with message-id <87k58x79zl.fsf@jurta.org>
and subject line Re: bug#1848: 23.0.60; isearch-forward fails to find colon characters in Info buffers
has caused the Emacs bug report #1848,
regarding 23.0.60; isearch-forward fails to find colon characters in Info buffers
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
1848: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1848
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 6419 bytes --]

From: Brent Goodrick <bgoodr@gmail.com>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.60; isearch-forward fails to find colon characters in Info buffers
Date: Sat, 10 Jan 2009 09:52:07 -0800
Message-ID: <18792.57415.297530.40046@hungover.brentg.com>


Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

1. Invoke Emacs CVS top of trunk on Debian Linux "testing" built as of today (2009-01-10). Pass
the -q option.
2. Type C-h i to view the Info buffer
3. Type d to get to the top node. Insure that there is an "Emacs"
node listed.
4. Type C-s which should be bound to isearch-forward
5. Type e
6. Type m
7. Type a
8. Type c
9. Type s
10. Type :
11. It fails to find the colon character.
12. Rerun the above steps again on Emacs 22-2 and it works as
expected.
13. Back in Emacs 23, copy and paste all of the Info buffer into some
other new scrap buffer, go to the top of the buffer and repeat steps 1
through 10 and it finds the colon.

Can someone double-check that this isn't a symptom of a more serious
change of behavior in isearch or elsewhere in Emacs 23?

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/home/brentg/emacs_from_source/install/share/emacs/23.0.60/etc/DEBUG for instructions.


In GNU Emacs 23.0.60.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.12.11)
 of 2009-01-10 on hungover
Windowing system distributor `The X.Org Foundation', version 11.0.10402000
configured using `configure  '--with-x-toolkit' '--with-xft' '--prefix=/home/brentg/emacs_from_source/install''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  desktop-save-mode: t
  iswitchb-mode: t
  erc-ring-mode: t
  erc-services-mode: t
  erc-networks-mode: t
  display-time-mode: t
  shell-dirtrack-mode: t
  delete-selection-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: 1
  transient-mark-mode: t

Recent input:
<down-mouse-1> <mouse-1> M-x r e p o r b 0 C-g C-h 
i C-s e m a c s : C-p q M-x r e p o r t - e m <tab> 
b u <tab> <return>

Recent messages:
Loading /home/brentg/emacs_lisp/bg-emacs.el (source)...done
Composing main Info directory...done
Desktop: 18 buffers restored.
For information about GNU Emacs and the GNU system, type C-h C-a.
Raising the Emacs window with: DISPLAY=:0.0 wmctrl -a 67109026 -i
Resizing The Emacs window with: DISPLAY=:0.0 wmctrl -r 67109026 -i -b add,maximized_vert,maximized_horz
Quit
Pushed a window configuration. [2 times]
Mark saved where search started
Pushed a window configuration.



[-- Attachment #3: Type: message/rfc822, Size: 1997 bytes --]

From: Juri Linkov <juri@jurta.org>
To: 1848-done@emacsbugs.donarmstrong.com
Cc: bgoodr@gmail.com
Subject: Re: bug#1848: 23.0.60; isearch-forward fails to find colon characters in Info buffers
Date: Thu, 15 Jan 2009 01:18:06 +0200
Message-ID: <87k58x79zl.fsf@jurta.org>

>> Then the following patch does this.  It checks only for
>> (eq search-invisible t), not for 'open.
>
> Looks fine.

Fixed.

-- 
Juri Linkov
http://www.jurta.org/emacs/