From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Virtual Info files and nodes Date: Mon, 29 Jun 2009 10:42:28 +0200 Message-ID: References: <87ws6wnj3s.fsf@mail.jurta.org> <87prcnhn4i.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1246264971 9262 80.91.229.12 (29 Jun 2009 08:42:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 29 Jun 2009 08:42:51 +0000 (UTC) Cc: emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 29 10:42:44 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MLCRl-0003Fd-0U for ged-emacs-devel@m.gmane.org; Mon, 29 Jun 2009 10:42:41 +0200 Original-Received: from localhost ([127.0.0.1]:40245 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MLCRk-0007tG-9e for ged-emacs-devel@m.gmane.org; Mon, 29 Jun 2009 04:42:40 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MLCRf-0007t5-K3 for emacs-devel@gnu.org; Mon, 29 Jun 2009 04:42:35 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MLCRa-0007sH-B3 for emacs-devel@gnu.org; Mon, 29 Jun 2009 04:42:34 -0400 Original-Received: from [199.232.76.173] (port=50757 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MLCRa-0007sE-99 for emacs-devel@gnu.org; Mon, 29 Jun 2009 04:42:30 -0400 Original-Received: from smtp-02.vtx.ch ([212.147.0.114]:40556) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MLCRZ-0003tf-Rw for emacs-devel@gnu.org; Mon, 29 Jun 2009 04:42:30 -0400 Original-Received: from alfajor.home (dyn.83-228-190-143.dsl.vtx.ch [83.228.190.143]) by smtp-02.vtx.ch (VTX Services SA) with ESMTP id 7BFF15FF35; Mon, 29 Jun 2009 10:42:28 +0200 (CEST) Original-Received: by alfajor.home (Postfix, from userid 20848) id 4351F64343; Mon, 29 Jun 2009 10:42:28 +0200 (CEST) In-Reply-To: <87prcnhn4i.fsf@mail.jurta.org> (Juri Linkov's message of "Mon, 29 Jun 2009 03:48:21 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.94 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:111806 Archived-At: >> - Why regexps for filenames? > This is a forethought for possible future cases. But maybe only strings > should be allowed now, and regexps can be added only when necessary. Nah, you might as well stick to regexps indeed. I'm not sure what I was thinking. >> - Why check (stringp filename) in Info-virtual-file? Isn't it an >> error to call it with something else than a string. > Really only nil can be expected now, Can it? In which circumstance? > but `stringp' is a precaution > against t (the current internal value for "dir" ) and former symbol > values `apropos', `toc' (maybe some external packages still use them). Please mention it in a comment. >> - Why have separate Info-virtual-file and Info-virtual-node functions? >> (the latter is only called (once) from Info-virtual-fun, and the former >> is called once from Info-virtual-fun and another time where it seems >> that Info-virtual-fun could be used in its stead). > Info-virtual-fun expects an argument `op' for an operation type, > but these places call (Info-virtual-file file) with only a file name > argument to check whether a file name is virtual (if its name is defined > in a list of definitions of virtual Info files). Why not provide a dummy `find-file' value for the `op'? And wrap this in an Info-virtual-file-p function? Stefan