From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juri Linkov <juri@jurta.org>
Cc: 4362@emacsbugs.donarmstrong.com
Subject: bug#4362: 23.1: proced -- Mode help lists 'd' as mark command (prefer 'm')
Date: Fri, 11 Sep 2009 01:13:30 -0400 [thread overview]
Message-ID: <jwvhbvaoym2.fsf-monnier+emacsbugreports@gnu.org> (raw)
In-Reply-To: <873a6ukyw3.fsf@mail.jurta.org> (Juri Linkov's message of "Fri, 11 Sep 2009 04:17:04 +0300")
> Using the `:advertised-binding' property just implemented by Stefan is
> a nice solution. But other changes in `where-is-internal' broke preferred
> key bindings in docstrings. For example, compare the old and new
> output of `C-h f Info-mode RET':
> - h Invoke the Info tutorial.
> + M-x Info-help Invoke the Info tutorial.
I just fixed this one. It was a plain bug.
> - u Move "up" from this node.
> + ^ Move "up" from this node.
> - t Go to the Top node of this file.
> + < Go to the Top node of this file.
> - b Go to beginning of node.
> + . Go to beginning of node.
> - w Put name of current Info node in the kill ring.
> + c Put name of current Info node in the kill ring.
These are trickier. I still haven't figured out why the preference
order has changed. Admittedly, this order was arbitrary (doesn't even
depend on the order of calls to define-key since these bindings are
stored in the vector part of a dense map) and is also arbitrary in the
new code, but it would be better to preserve the old order.
> Should we put `:advertised-binding' for all old preferred key bindings
> explicitly?
Arguably, it would be good, yes. But first, I'll try to adjust the code
to get back the original behavior. Thanks for bringing it up.
Stefan
prev parent reply other threads:[~2009-09-11 5:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <l2y6orcwhd.fsf@fencepost.gnu.org>
2009-09-06 17:28 ` bug#4362: 23.1: proced -- Mode help lists 'd' as mark command (prefer 'm') Jari Aalto
2009-09-07 2:45 ` bug#4362: marked as done (23.1: proced -- Mode help lists 'd' as mark command (prefer 'm')) Emacs bug Tracking System
2009-09-09 0:57 ` bug#4362: 23.1: proced -- Mode help lists 'd' as mark command (prefer 'm') Juri Linkov
2009-09-10 1:16 ` Juri Linkov
2009-09-10 6:27 ` Glenn Morris
2009-09-11 1:17 ` Juri Linkov
2009-09-11 5:13 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvhbvaoym2.fsf-monnier+emacsbugreports@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=4362@emacsbugs.donarmstrong.com \
--cc=juri@jurta.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.