From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: /srv/bzr/emacs/trunk r102179: Silence gnus-util.el compilation. Date: Mon, 01 Nov 2010 14:08:59 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1288634962 786 80.91.229.12 (1 Nov 2010 18:09:22 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 1 Nov 2010 18:09:22 +0000 (UTC) Cc: emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 01 19:09:17 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PCyom-0002EB-Ua for ged-emacs-devel@m.gmane.org; Mon, 01 Nov 2010 19:09:17 +0100 Original-Received: from localhost ([127.0.0.1]:48943 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PCyol-0006AZ-CU for ged-emacs-devel@m.gmane.org; Mon, 01 Nov 2010 14:09:15 -0400 Original-Received: from [140.186.70.92] (port=34431 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PCyoa-00068s-T2 for emacs-devel@gnu.org; Mon, 01 Nov 2010 14:09:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PCyoW-0008NA-OF for emacs-devel@gnu.org; Mon, 01 Nov 2010 14:09:01 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.183]:41352 helo=ironport2-out.pppoe.ca) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PCyoW-0008Mx-Lr; Mon, 01 Nov 2010 14:09:00 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Au4IAOSezkxFpZAX/2dsb2JhbACgYX1yvzuFRQSSKw X-IronPort-AV: E=Sophos;i="4.58,275,1286164800"; d="scan'208";a="81281526" Original-Received: from 69-165-144-23.dsl.teksavvy.com (HELO pastel.home) ([69.165.144.23]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 01 Nov 2010 14:08:59 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 0E068A862F; Mon, 1 Nov 2010 14:08:59 -0400 (EDT) In-Reply-To: (Glenn Morris's message of "Mon, 01 Nov 2010 12:35:46 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:132248 Archived-At: >>> -(autoload 'iswitchb-read-buffer "iswitchb") >>> +(declare-function iswitchb-read-buffer "iswitchb" >>> + (prompt &optional default require-match start matches-set)) >>> +(defvar iswitchb-temp-buflist) >>> + >>> (defun gnus-iswitchb-completing-read (prompt collection &optional require-match >>> initial-input history def) >>> "`iswitchb' based completing-read function." >>> + (require 'iswitchb) >>> (let ((iswitchb-make-buflist-hook >>> (lambda () >>> (setq iswitchb-temp-buflist >> >> I'm not convinced that declare-function+require is better than autoload. >> What was the problem with autoload? > It might load iswitchb while an iswitchb variable was let bound. Eg: I see, thanks. Then it would have been good to add a comment before the `require' reminding future readers why we did it this way. > PS could you reply to emacs-devel rather than emacs-diffs in these cases? > (I don't know why emacs-diffs is even configured to accept postings > other than from Savannah.) Yes, I get bitten by this all the time. Indeed emacs-diffs should refuse such postings. Stefan