From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] minibuffer issue with eshell-command Date: Thu, 06 Oct 2011 11:36:33 -0400 Message-ID: References: <87lisy7g00.fsf@gmail.com> <87hb3me15c.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; CHARSET=US-ASCII Content-Transfer-Encoding: 7BIT X-Trace: dough.gmane.org 1317915620 8124 80.91.229.12 (6 Oct 2011 15:40:20 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 6 Oct 2011 15:40:20 +0000 (UTC) Cc: emacs-devel@gnu.org To: Thierry Volpiatto Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 06 17:40:16 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RBq3T-0005Fj-1w for ged-emacs-devel@m.gmane.org; Thu, 06 Oct 2011 17:40:15 +0200 Original-Received: from localhost ([::1]:51759 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RBq3S-0006HB-Fo for ged-emacs-devel@m.gmane.org; Thu, 06 Oct 2011 11:40:14 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:37515) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RBq3L-0005wJ-AK for emacs-devel@gnu.org; Thu, 06 Oct 2011 11:40:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RBq3G-0004yk-Go for emacs-devel@gnu.org; Thu, 06 Oct 2011 11:40:07 -0400 Original-Received: from relais.videotron.ca ([24.201.245.36]:49186) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RBq3G-0004yg-8h for emacs-devel@gnu.org; Thu, 06 Oct 2011 11:40:02 -0400 Original-Received: from ceviche.home ([70.83.132.46]) by VL-VM-MR004.ip.videotron.ca (Oracle Communications Messaging Exchange Server 7u4-22.01 64bit (built Apr 21 2011)) with ESMTP id <0LSN00HV1I1HYI70@VL-VM-MR004.ip.videotron.ca> for emacs-devel@gnu.org; Thu, 06 Oct 2011 11:36:55 -0400 (EDT) Original-Received: by ceviche.home (Postfix, from userid 20848) id 62C0A66492; Thu, 06 Oct 2011 11:36:33 -0400 (EDT) In-reply-to: <87hb3me15c.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 24.201.245.36 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:144618 Archived-At: >> When eshell-command start, it set eshell-mode in all minibuffers: >> ;(add-hook 'minibuffer-setup-hook 'eshell-mode) >> So when running another minibuffer, while eshell-command is started, >> it enable eshell-mode in this one, which is wrong. >> This patch fix this: > Any objections to push this on trunk? That looks OK, except that I think the add-hooks should be moved to the setup-hook function where they can be made to only apply locally (and I guess at that point you can get rid of the remove-hooks). Stefan