From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Thierry Volpiatto <thierry.volpiatto@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] minibuffer issue with eshell-command
Date: Thu, 06 Oct 2011 11:36:33 -0400 [thread overview]
Message-ID: <jwvhb3mw2vd.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87hb3me15c.fsf@gmail.com>
>> When eshell-command start, it set eshell-mode in all minibuffers:
>> ;(add-hook 'minibuffer-setup-hook 'eshell-mode)
>> So when running another minibuffer, while eshell-command is started,
>> it enable eshell-mode in this one, which is wrong.
>> This patch fix this:
> Any objections to push this on trunk?
That looks OK, except that I think the add-hooks should be moved to the
setup-hook function where they can be made to only apply locally (and
I guess at that point you can get rid of the remove-hooks).
Stefan
next prev parent reply other threads:[~2011-10-06 15:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-06 7:09 [PATCH] minibuffer issue with eshell-command Thierry Volpiatto
2011-10-06 12:48 ` Thierry Volpiatto
2011-10-06 15:00 ` Chong Yidong
2011-10-06 15:36 ` Stefan Monnier [this message]
2011-10-06 16:22 ` Thierry Volpiatto
2011-10-07 14:04 ` Thierry Volpiatto
2011-10-07 19:12 ` Thierry Volpiatto
2011-10-10 18:36 ` Thierry Volpiatto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvhb3mw2vd.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=thierry.volpiatto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.