From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Leo <sdl.web@gmail.com>
Cc: Lars Magne Ingebrigtsen <larsi@gnus.org>, 10063@debbugs.gnu.org
Subject: bug#10063: 24.0.91; Making font-lock-mode-hook buffer-local while locally let-bound!
Date: Wed, 16 Nov 2011 09:49:37 -0500 [thread overview]
Message-ID: <jwvhb245drl.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87y5vg5jzb.fsf@gmail.com> (Leo's message of "Wed, 16 Nov 2011 20:29:12 +0800")
> I am seeing this warning in Gnus.
> ,----
> | Making font-lock-mode-hook buffer-local while locally let-bound!
> `----
> which seems to relate to line 602 in mm-view.el
> 601: ;; Disable support modes, e.g., jit-lock, lazy-lock, etc.
> 602: (font-lock-mode-hook nil)
> 603: (font-lock-support-mode nil)
BTW, these should not be let-bindings but buffer-local bindings.
Also the mode-setting and font-locking should be wrapped in
with-demoted-errors so that errors in them don't prevent showing the
attachment's content.
Finally, font-lock-maximum-size should not be set to nil: there is
nothing special about font-locking attachments that makes it more
desirable to font-lock them entirely than normal files.
Stefan
next prev parent reply other threads:[~2011-11-16 14:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 12:29 bug#10063: 24.0.91; Making font-lock-mode-hook buffer-local while locally let-bound! Leo
2011-11-16 14:49 ` Stefan Monnier [this message]
2011-11-21 19:37 ` Lars Magne Ingebrigtsen
2011-12-26 20:02 ` Wolfgang Jenkner
2011-12-26 23:36 ` Katsumi Yamaoka
2011-12-27 1:29 ` Stefan Monnier
2011-12-28 2:40 ` Katsumi Yamaoka
2011-12-27 16:26 ` Wolfgang Jenkner
2011-12-27 19:48 ` Wolfgang Jenkner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvhb245drl.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=10063@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.