From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#10956: make-mode.el - improve makefile-warn-suspicious-lines Date: Thu, 22 Mar 2012 12:36:48 -0400 Message-ID: References: <62ehq5qt.fsf@test20.cante.net> <20120321185242.GE28863@taiko.cante.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1332434256 9146 80.91.229.3 (22 Mar 2012 16:37:36 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 22 Mar 2012 16:37:36 +0000 (UTC) Cc: 10956@debbugs.gnu.org To: jaalto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 22 17:37:35 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SAl10-00041u-PF for geb-bug-gnu-emacs@m.gmane.org; Thu, 22 Mar 2012 17:37:30 +0100 Original-Received: from localhost ([::1]:35165 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SAl10-0001ow-6H for geb-bug-gnu-emacs@m.gmane.org; Thu, 22 Mar 2012 12:37:30 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40500) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SAl0s-0001g4-EQ for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2012 12:37:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SAl0k-0004aH-SZ for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2012 12:37:21 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54813) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SAl0k-0004a6-PD for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2012 12:37:14 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SAlUY-0003Us-C4 for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2012 13:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Mar 2012 17:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10956 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 10956-submit@debbugs.gnu.org id=B10956.133243608113435 (code B ref 10956); Thu, 22 Mar 2012 17:08:02 +0000 Original-Received: (at 10956) by debbugs.gnu.org; 22 Mar 2012 17:08:01 +0000 Original-Received: from localhost ([127.0.0.1]:33412 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SAlUV-0003UU-Mi for submit@debbugs.gnu.org; Thu, 22 Mar 2012 13:08:00 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:34884) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SAlU9-0003Sh-N5 for 10956@debbugs.gnu.org; Thu, 22 Mar 2012 13:07:57 -0400 Original-Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q2MGamc4025115; Thu, 22 Mar 2012 12:36:48 -0400 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 264B3B44C1; Thu, 22 Mar 2012 12:36:48 -0400 (EDT) In-Reply-To: <20120321185242.GE28863@taiko.cante.net> (jaalto's message of "Wed, 21 Mar 2012 14:52:42 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4169=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4169> : streams <740170> : uri <1087864> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:57969 Archived-At: > | > Here is a small patch to check any extra whitespace at the beginning of > | > line. The patch is against Emacs Vcs-Git ba7322c dated 2012-02-29. > | I must be missing something. All it does is change a "\t+$" to > | "[ \t]+$", so it's not really "at the beginning of line" (tho there's > | also a "^" in the regexp, so it really only applies to whitespace-only > | lines). > | I don't think we want to consider lines made up of spaces as suspicious. > It would be good if any whitespace only line were flagged as suspicious, > not just \t, like in: > [SPACE][TAB][SPACE] > [SPACE][TAB] > [TAB][SPACE] > [TAB] > These extra "whitespace" lines are easily missed unless > whitespace-mode is on. I notice the absence of a line with only spaces in your examples. Would you consider such a line as suspicious? Could you expand on why you consider your examples as suspicious? I think I'd agree with "\t[ \t]*" since such lines behave identically to TAB-only lines, but I'm not so sure about lines starting with a space. Since such suspicious lines end up prompting the user, we had better be sure they're really risky, otherwise we might bother people for no good reason. Stefan