From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juri Linkov <juri@jurta.org>
Cc: 11381@debbugs.gnu.org
Subject: bug#11381: 23.3; isearch-search-and-update issue?
Date: Mon, 28 May 2012 10:08:15 -0400 [thread overview]
Message-ID: <jwvhav07arf.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87y5oc3cab.fsf@mail.jurta.org> (Juri Linkov's message of "Mon, 28 May 2012 11:55:20 +0300")
>> Do we really need those 4? I think we can just get away with
>> symbol-search-regexp (whose name also needs to start with "isearch-").
> In the next patch these functions are removed and symbol-search-regexp
> is renamed to isearch-symbol-regexp.
Thanks, see comments below.
>>> Also it splits the standard default part of `isearch-search-fun'
>> You could actually set isearch-search-fun-function's default to
>> isearch-search-fun-default so we can just unconditionally call
>> isearch-search-fun-function's.
> It still needs protection against such cases as currently existing in
> several places in internal and probably also in external packages:
> (let ((isearch-search-fun-function nil))
> (isearch-search-fun))
For the internal cases, the above should be replaced by a call to
isearch-search-fun-default. Obviously, if there are external such
cases, we'll indeed need to additionally keep:
> (funcall (or isearch-search-fun-function 'isearch-search-fun-default))
[...]
> === modified file 'lisp/isearch.el'
> --- lisp/isearch.el 2012-05-17 00:03:49 +0000
> +++ lisp/isearch.el 2012-05-28 08:38:31 +0000
> @@ -503,6 +512,7 @@ (defvar isearch-mode-map
> (define-key map "\M-sr" 'isearch-toggle-regexp)
> (define-key map "\M-sw" 'isearch-toggle-word)
> + (define-key map "\M-s_" 'isearch-toggle-symbol)
BTW, could you add isearch-toggle-case-fold to the M-s prefix, while
you're at it?
> (defun Info-isearch-search ()
I think we can share even more code here with isearch.el.
But in any case, the patch looks good now, thank you,
Stefan
next prev parent reply other threads:[~2012-05-28 14:08 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-29 22:31 bug#11381: 23.3; isearch-search-and-update issue? Andy Grover
2012-04-30 0:27 ` Juri Linkov
2012-05-01 9:03 ` Juri Linkov
2012-05-01 13:08 ` Stefan Monnier
2012-05-01 15:17 ` Juri Linkov
2012-05-15 21:35 ` Juri Linkov
2012-05-16 2:35 ` Stefan Monnier
2012-05-17 0:08 ` Juri Linkov
2012-05-20 0:15 ` Juri Linkov
2012-05-21 1:36 ` Stefan Monnier
2012-05-21 2:23 ` Stefan Monnier
2012-05-27 9:43 ` Juri Linkov
2012-05-28 4:48 ` Stefan Monnier
2012-05-28 8:55 ` Juri Linkov
2012-05-28 14:08 ` Stefan Monnier [this message]
2012-05-29 9:49 ` Juri Linkov
2012-05-29 13:34 ` Stefan Monnier
2012-05-27 9:35 ` Juri Linkov
2012-05-28 4:23 ` Stefan Monnier
2012-05-28 15:44 ` Eli Zaretskii
2012-05-28 17:34 ` bug#11381: use and doc of function symbol properties [was: bug#11381: 23.3; isearch-search-and-update issue?] Drew Adams
2012-05-28 17:34 ` Drew Adams
2012-05-28 17:53 ` Eli Zaretskii
2012-05-28 18:26 ` Drew Adams
2012-05-28 20:43 ` Eli Zaretskii
2012-05-30 0:10 ` Drew Adams
2012-06-02 16:47 ` Eli Zaretskii
2012-06-02 16:57 ` Drew Adams
2012-06-02 17:52 ` Drew Adams
2012-05-28 19:34 ` bug#11381: 23.3; isearch-search-and-update issue? Stefan Monnier
2012-05-29 0:27 ` Juri Linkov
2012-05-29 1:26 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvhav07arf.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=11381@debbugs.gnu.org \
--cc=juri@jurta.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.