bug#13724: Calling 'org-babel-mark-block' with 'M-x cmd' and 'M-: (cmd)'

bug#13724: Calling 'org-babel-mark-block' with 'M-x cmd' and 'M-: (cmd)'

[Stefan Monnier]

[-- Attachment #1: Type: text/plain, Size: 26 bytes --]

Get a bug-number for it.


[-- Attachment #2: Type: message/rfc822, Size: 4954 bytes --]

From: Thorsten Jolitz <tjolitz@gmail.com>
To: emacs-devel@gnu.org
Subject: Calling 'org-babel-mark-block' with 'M-x cmd' and 'M-: (cmd)'
Date: Fri, 15 Feb 2013 14:55:01 +0100
Message-ID: <871uchk7gq.fsf@gmail.com>


Hi List, 

this was posted and discussed on the Org-mode mailing list, but without
any real conclusion if it is a Bug in Emacs - or something else. So it
was suggested to repost it here. 

Say point is behind the closing parenthesis of the sexp in this Org-mode source
block:

,-------------------------------------
| #+begin_src emacs-lisp
| (+ 3 4)          # point behind sexp
| #+end_src
`-------------------------------------

Now, when I call

,-----------------------------
| M-x org-babel-mark-block RET
`-----------------------------

or

,-------------------------
| M-x org-mark-element RET
`-------------------------

the body of the source block (or the whole source-block) is (visibly)
marked as expected (transient-mark-mode is on), and 'M-w' puts the
active region into the kill-ring. 

But with the point at the same position, doing

,-----------------------------
| M-: (org-babel-mark-block) RET
`-----------------------------

or

,-------------------------
| M-: (org-mark-element) RET
`-------------------------

moves point to the beginning of source-block (body) and returns the
position of point without (visibly) marking the source-block body.
There is no region activated, 'M-w' puts nothing in the kill-ring. 

-- 
cheers,
Thorsten

bug#13724: Calling 'org-babel-mark-block' with 'M-x cmd' and 'M-: (cmd)'

[Bastien]

Let me restate the issue:

M-x mark-word RET will highlight the word at point.
M-: (mark-word) RET will *not* highlight the word at point.

My understanding was that interactive call of mark-word
highlight the region, while non-interactive call do not
highlight it.

Is this wrong?

`org-mark-element' and `org-babel-mark-block' are not
different to `mark-word' here.

-- 
 Bastien

bug#13724: Calling 'org-babel-mark-block' with 'M-x cmd' and 'M-: (cmd)'

[Bastien]

Let me restate the issue:

M-x mark-word RET will highlight the word at point.
M-: (mark-word) RET will *not* highlight the word at point.

My understanding was that interactive call of mark-word
highlight the region, while non-interactive call do not
highlight it.

Is this wrong?

`org-mark-element' and `org-babel-mark-block' are not
different to `mark-word' here.

-- 
 Bastien

bug#13724: Calling 'org-babel-mark-block' with 'M-x cmd' and 'M-: (cmd)'

[Stefan Monnier]

> ,-------------------------
> | M-: (org-mark-element) RET
> `-------------------------
> moves point to the beginning of source-block (body) and returns the
> position of point without (visibly) marking the source-block body.

Indeed, thank you.  Should be fixed now, thanks to the patch below,


        Stefan


--- lisp/simple.el	2013-02-12 04:46:18 +0000
+++ lisp/simple.el	2013-02-15 17:35:00 +0000
@@ -1328,7 +1327,8 @@
 	(setq debug-on-error new-value))))
 
   (let ((print-length eval-expression-print-length)
-	(print-level eval-expression-print-level))
+	(print-level eval-expression-print-level)
+        (deactivate-mark))
     (if eval-expression-insert-value
 	(with-no-warnings
 	 (let ((standard-output (current-buffer)))

bug#13724: Calling 'org-babel-mark-block' with 'M-x cmd' and 'M-: (cmd)'

[Stefan Monnier]

> ,-------------------------
> | M-: (org-mark-element) RET
> `-------------------------
> moves point to the beginning of source-block (body) and returns the
> position of point without (visibly) marking the source-block body.

Indeed, thank you.  Should be fixed now, thanks to the patch below,


        Stefan


--- lisp/simple.el	2013-02-12 04:46:18 +0000
+++ lisp/simple.el	2013-02-15 17:35:00 +0000
@@ -1328,7 +1327,8 @@
 	(setq debug-on-error new-value))))
 
   (let ((print-length eval-expression-print-length)
-	(print-level eval-expression-print-level))
+	(print-level eval-expression-print-level)
+        (deactivate-mark))
     (if eval-expression-insert-value
 	(with-no-warnings
 	 (let ((standard-output (current-buffer)))