From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#13963: 24.3; eshell: "Text is read-only" and unresponsive eshell to kill-buffer, C-x C-c and C-x C-q Date: Sat, 23 Mar 2013 11:58:52 -0400 Message-ID: References: <87a9q5qfou.fsf@gmail.com> <87ehfe6q2p.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1364054344 31134 80.91.229.3 (23 Mar 2013 15:59:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 23 Mar 2013 15:59:04 +0000 (UTC) Cc: 13963@debbugs.gnu.org To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 23 16:59:30 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UJQqv-0006pA-QM for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Mar 2013 16:59:29 +0100 Original-Received: from localhost ([::1]:52359 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UJQqY-0007L7-D3 for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Mar 2013 11:59:06 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:49341) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UJQqU-0007HH-Rr for bug-gnu-emacs@gnu.org; Sat, 23 Mar 2013 11:59:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UJQqT-000278-4W for bug-gnu-emacs@gnu.org; Sat, 23 Mar 2013 11:59:02 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38283) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UJQqT-00026z-2I for bug-gnu-emacs@gnu.org; Sat, 23 Mar 2013 11:59:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UJQsQ-0006yA-Cg for bug-gnu-emacs@gnu.org; Sat, 23 Mar 2013 12:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Mar 2013 16:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13963 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13963-submit@debbugs.gnu.org id=B13963.136405445926781 (code B ref 13963); Sat, 23 Mar 2013 16:01:02 +0000 Original-Received: (at 13963) by debbugs.gnu.org; 23 Mar 2013 16:00:59 +0000 Original-Received: from localhost ([127.0.0.1]:42392 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UJQsM-0006xu-PV for submit@debbugs.gnu.org; Sat, 23 Mar 2013 12:00:59 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:45087) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UJQsL-0006xm-5F for 13963@debbugs.gnu.org; Sat, 23 Mar 2013 12:00:57 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AsAJABK/CFFFxLSu/2dsb2JhbABEgiu5CoNZF3OCHgEBBAFWIxALNAcLFBgNJIgeBsEtkQoDpHqBXoMT X-IPAS-Result: AsAJABK/CFFFxLSu/2dsb2JhbABEgiu5CoNZF3OCHgEBBAFWIxALNAcLFBgNJIgeBsEtkQoDpHqBXoMT X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="5619075" Original-Received: from 69-196-180-174.dsl.teksavvy.com (HELO pastel.home) ([69.196.180.174]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 23 Mar 2013 11:58:51 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 0B9B567A38; Sat, 23 Mar 2013 11:58:53 -0400 (EDT) In-Reply-To: <87ehfe6q2p.fsf@gmail.com> (Thierry Volpiatto's message of "Sun, 17 Mar 2013 15:47:26 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:72834 Archived-At: >> The problem I think is that the eshell prompt is read-only but this >> doesn't forbid user to write in this zone and because the prompt have >> also rear-nonsticky property, the new character entered are made >> read-only and eshell when it try to delete this characters return "text >> read only". >> Didn't look deeper where this happen though. The problem is that the last char of the prompt (the space) should be rear-nonsticky, but if the others are rear-nonsticky and are not front-sticky, then indeed you can't erase them but you can insert anything inside them. So I think the better fix is to make the prompt (including the trailing space) both rear-nonsticky and front-sticky. Does the patch below fix the problem? Stefan === modified file 'lisp/eshell/em-prompt.el' --- lisp/eshell/em-prompt.el 2013-01-01 09:11:05 +0000 +++ lisp/eshell/em-prompt.el 2013-03-23 15:57:29 +0000 @@ -122,6 +122,7 @@ (add-text-properties 0 (length prompt) '(read-only t face eshell-prompt + front-sticky (face read-only) rear-nonsticky (face read-only)) prompt)) (eshell-interactive-print prompt)))