From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r113497: lisp/desktop.el: Simplify. Date: Mon, 22 Jul 2013 21:25:19 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1374542729 6950 80.91.229.3 (23 Jul 2013 01:25:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 23 Jul 2013 01:25:29 +0000 (UTC) Cc: emacs-devel@gnu.org To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 23 03:25:27 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1V1RLy-0002Dj-Jy for ged-emacs-devel@m.gmane.org; Tue, 23 Jul 2013 03:25:26 +0200 Original-Received: from localhost ([::1]:45337 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1RLx-0005Gu-Ub for ged-emacs-devel@m.gmane.org; Mon, 22 Jul 2013 21:25:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1RLu-0005Gp-EN for emacs-devel@gnu.org; Mon, 22 Jul 2013 21:25:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1RLs-0001GD-LF for emacs-devel@gnu.org; Mon, 22 Jul 2013 21:25:22 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:58979) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1RLs-0001G4-HH for emacs-devel@gnu.org; Mon, 22 Jul 2013 21:25:20 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFsoXa8/2dsb2JhbABEvw4Xc4IfAQVWIxALDiYSFBgNJIgkwS2RCgOkeoFegxM X-IPAS-Result: Av4EABK/CFFsoXa8/2dsb2JhbABEvw4Xc4IfAQVWIxALDiYSFBgNJIgkwS2RCgOkeoFegxM X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="19577091" Original-Received: from 108-161-118-188.dsl.teksavvy.com (HELO pastel.home) ([108.161.118.188]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 22 Jul 2013 21:25:13 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 583D162CA8; Mon, 22 Jul 2013 21:25:19 -0400 (EDT) In-Reply-To: (Juanma Barranquero's message of "Tue, 23 Jul 2013 01:11:01 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:162080 Archived-At: > (defun desktop-list* (&rest args) > - (if (null (cdr args)) > - (car args) > - (setq args (nreverse args)) > - (let ((value (cons (nth 1 args) (car args)))) > - (setq args (cdr (cdr args))) > - (while args > - (setq value (cons (car args) value)) > - (setq args (cdr args))) > - value))) > + (and args (cl-list* args))) Doesn't look right. Shouldn't it be (and args (apply #'cl-list* args)) or more simply (apply #'cl-list* args) which boils down to (defalias 'desktop-list* 'cl-list*) -- Stefan