From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] trunk r113497: lisp/desktop.el: Simplify.
Date: Mon, 22 Jul 2013 21:25:19 -0400 [thread overview]
Message-ID: <jwvhafmul0w.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <E1V1R81-0005Jw-15@vcs.savannah.gnu.org> (Juanma Barranquero's message of "Tue, 23 Jul 2013 01:11:01 +0000")
> (defun desktop-list* (&rest args)
> - (if (null (cdr args))
> - (car args)
> - (setq args (nreverse args))
> - (let ((value (cons (nth 1 args) (car args))))
> - (setq args (cdr (cdr args)))
> - (while args
> - (setq value (cons (car args) value))
> - (setq args (cdr args)))
> - value)))
> + (and args (cl-list* args)))
Doesn't look right. Shouldn't it be
(and args (apply #'cl-list* args))
or more simply
(apply #'cl-list* args)
which boils down to
(defalias 'desktop-list* 'cl-list*)
-- Stefan
next parent reply other threads:[~2013-07-23 1:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1V1R81-0005Jw-15@vcs.savannah.gnu.org>
2013-07-23 1:25 ` Stefan Monnier [this message]
2013-07-23 3:14 ` [Emacs-diffs] trunk r113497: lisp/desktop.el: Simplify Stephen J. Turnbull
2013-07-23 11:23 ` Juanma Barranquero
2013-07-23 13:42 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvhafmul0w.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.