From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [patch] make electric-pair-mode smarter/more useful Date: Sat, 14 Dec 2013 10:18:15 -0500 Message-ID: References: <87haalh806.fsf@gmail.com> <87d2l9wfne.fsf@yandex.ru> <87fvq49xzp.fsf@gmail.com> <87vbyuwyyc.fsf@gmail.com> <52A93B99.8040308@yandex.ru> <87r49if185.fsf@gmail.com> <52AA772D.7050503@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1387034318 32017 80.91.229.3 (14 Dec 2013 15:18:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 14 Dec 2013 15:18:38 +0000 (UTC) Cc: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= , emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 14 16:18:43 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VrqzI-0006wy-9x for ged-emacs-devel@m.gmane.org; Sat, 14 Dec 2013 16:18:40 +0100 Original-Received: from localhost ([::1]:47641 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrqzH-0002Sp-Q1 for ged-emacs-devel@m.gmane.org; Sat, 14 Dec 2013 10:18:39 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60419) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vrqz7-0002SZ-3l for emacs-devel@gnu.org; Sat, 14 Dec 2013 10:18:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vrqyz-0002BF-Ql for emacs-devel@gnu.org; Sat, 14 Dec 2013 10:18:29 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:46931) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vrqyz-0002BB-LP for emacs-devel@gnu.org; Sat, 14 Dec 2013 10:18:21 -0500 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id rBEFIGtd025457; Sat, 14 Dec 2013 10:18:16 -0500 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 18FF0AE358; Sat, 14 Dec 2013 10:18:15 -0500 (EST) In-Reply-To: <52AA772D.7050503@yandex.ru> (Dmitry Gutov's message of "Fri, 13 Dec 2013 04:55:41 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4792=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4792> : inlines <324> : streams <1090752> : uri <1623811> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:166389 Archived-At: >> ;;; Electric newlines after/before/around some chars. >> >> -(defvar electric-layout-rules '() >> +(defvar electric-layout-rules `((?\n . ,#'electric-pair-newline-between-pairs-rule)) > Guess I'm a bit late with this comment (sorry), but does this mean that the > usage of the electric newline would be set on per-mode basis? I'm not completely sure I understand our question w.r.t the code you quoted: the code you quoted adds the behavior globally, so it obviously wouldn't be set on a per-mode basis. > For example, like described previously, if I want js-mode to only insert > electric newlines when I press return, will I have to modify > electric-layout-rules in js-mode-hook, and do so for any other mode I use > that sets this variable? I think setting it on a per-mode basis would be OK, but it wouldn't be set by the user but instead by the major mode, based on the usual coding style used for that mode. E.g. we wouldn't set it in Lisp, but we'd set it in js-mode. > Wouldn't a separate minor mode be better, electric-newline-mode maybe? I don't see for it, currently. It should depend on electric-layout-mode, tho, of course. Stefan